-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new server option ansi_mode. #348
Conversation
This mode currently enables the following settings when connecting to SQL Servers: CONCAT_NULLS_YIELDS_NULL ON ANSI_NULLS ON ANSI_WARNINGS ON ANSI_PADDING ON QUOTED_IDENTIFER ON ANSI_NULL_DFLT_ON Since we support the new option `sqlserver_ansi_mode` only for SQL Server, error out in case we don't find such a backend. This also moves the check for the backend vendor into a separate function `tdsIsSqlServer()`, additionally used by `tdsImportForeignSchema()`. Documentation for `sqlserver_ansi_mode` updated accordingly.
Can one of the admins verify this patch? |
Test this, please |
Test PASSed. |
Hi @psoo, Thanks for the squashed patch! It looks like the
Shouldn't one of these be removed? If you fix this issue, then I will merge the patch. Thanks! |
Oh yes, looks like a copy&past mistake...sorry for this, didn't see this before pushing. Fixed. |
Test this, please |
Test PASSed. |
This has been merged. Thanks again for the patch! |
Follow up PR for #347 with suggested changes, squashed commits.