Introduce new server option ansi_mode. #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mode currently enables the following settings when connecting to SQL Servers: CONCAT_NULLS_YIELDS_NULL ON ANSI_NULLS ON ANSI_WARNINGS ON ANSI_PADDING ON QUOTED_IDENTIFER ON ANSI_NULL_DFLT_ON Since we support the new option `sqlserver_ansi_mode` only for SQL Server, error out in case we don't find such a backend. This also moves the check for the backend vendor into a separate function `tdsIsSqlServer()`, additionally used by `tdsImportForeignSchema()`. Documentation for `sqlserver_ansi_mode` updated accordingly.
|
Can one of the admins verify this patch? |
|
Test this, please |
|
Test PASSed. |
|
Hi @psoo, Thanks for the squashed patch! It looks like the Shouldn't one of these be removed? If you fix this issue, then I will merge the patch. Thanks! |
|
Oh yes, looks like a copy&past mistake...sorry for this, didn't see this before pushing. Fixed. |
|
Test this, please |
|
Test PASSed. |
|
This has been merged. Thanks again for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR for #347 with suggested changes, squashed commits.