Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add upgrade route from 2.0.1 to 2.0.3 #339

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

kav23alex
Copy link

Fix for the ability to upgrade from version 2.0.1 to 2.0.3
Update from version 1.0.0 intentionally skipped

@jenkins-juliogonzalez
Copy link
Member

Can one of the admins verify this patch?

@jcarnu
Copy link
Contributor

jcarnu commented Sep 28, 2023 via email

@GeoffMontee
Copy link
Collaborator

Test this, please

@jenkins-juliogonzalez
Copy link
Member

Test PASSed.

@GeoffMontee
Copy link
Collaborator

Hi @kav23alex,

I just took a look at the upgrade script for postgres_fdw, and it has some lines like this:

-- complain if script is sourced in psql, rather than via ALTER EXTENSION
\echo Use "ALTER EXTENSION postgres_fdw UPDATE TO '1.1'" to load this file. \quit`

See here: https://github.com/postgres/postgres/blob/REL_16_0/contrib/postgres_fdw/postgres_fdw--1.0--1.1.sql#L3

Maybe it would make sense to add similar lines to the tds_fdw upgrade scripts? e.g.:

-- complain if script is sourced in psql, rather than via ALTER EXTENSION
\echo Use "ALTER EXTENSION tds_fdw UPDATE TO '2.0.3'" to load this file. \quit

What do you think?

@kav23alex
Copy link
Author

@GeoffMontee, Thank you, fixed it.

@GeoffMontee
Copy link
Collaborator

Thank you!

Test this, please

@jenkins-juliogonzalez
Copy link
Member

Test PASSed.

@GeoffMontee GeoffMontee merged commit 22ee5d3 into tds-fdw:master Sep 28, 2023
1 check passed
@GeoffMontee
Copy link
Collaborator

This PR has been merged. Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants