Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert go_kraken/websocket package #21

Merged
merged 7 commits into from
May 5, 2021
Merged

Revert go_kraken/websocket package #21

merged 7 commits into from
May 5, 2021

Conversation

louisinger
Copy link
Contributor

This PR removes go_kraken, and reuses v0.0.1 WebSocket implementation

  • Remove go_kraken in go.mod
  • Remove kraken_ws_endpoint from config.json files
  • Reuse former functions from v0.0.1 in ports/socket_utils.go
  • Reimplement go_kraken behavior using gorilla/websocket package in ports/kraken_websocket.go
  • add TestStop in kraken_websocket_test.go

it closes #13
it closes #20
it closes #19

please @tiero review this

@louisinger louisinger requested a review from tiero May 2, 2021 08:14
@tiero tiero merged commit 71ec31c into tdex-network:master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiero tiero Awaiting requested review from tiero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@louisinger @tiero