Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wide refactoring of WebUI, UITab, and UIPage #5

Merged
merged 1 commit into from
Apr 11, 2014
Merged

Wide refactoring of WebUI, UITab, and UIPage #5

merged 1 commit into from
Apr 11, 2014

Commits on Apr 11, 2014

  1. Wide refactoring of WebUI, UITab, and UIPage (see commit message) 

    The biggest changes include
(1) Decoupling the SparkListener from any member of the hierarchy. This was
    previously arbitrarily tied to the UITab.
(2) Decoupling initializing a UITab from attaching it to a WebUI. This involves
    having each UITab initializing itself instead.
(3) Add an abstract parent for each UITab. This allows us to move the access
    of header tabs of the UI into the UITab abstract class itself.
(4) Abstract bind() logic into WebUI.
(5) Renaming UITab -> WebUITab, and UIPage -> WebUIPage.
    @andrewor14
    andrewor14 committed Apr 11, 2014
    Configuration menu
    Copy the full SHA
    548c98c View commit details
    Browse the repository at this point in the history