Empty sequence crash #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PlayerDisplay has been created. Retry 3 times to find the display in case it is eventually created, so it can be removed from the current party
sonicolasj
approved these changes
Mar 7, 2022
PlayerCollection.cs
Outdated
| Logger.Error($"Caught exception while trying to get PlayerDisplay to remove from Current Squad Members: {ex}"); | ||
| playerDisplay = null; | ||
| return false; | ||
| } |
There was a problem hiding this comment.
No need to use a try/catch block, you can replace First by FirstOrDefault, which returns null instead of throwing when nothing has been found
There was a problem hiding this comment.
I've pushed a change for this - couldn't see a need to keep the logging statement. Anything you'd log here?
|
Also, did you include your WIP README on purpose? |
I didn't, but I don't mind including it now anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #26. Wasn't able to reproduce the bug, but looking through the code, this could avoid a potential race condition, in which a player leaves the squad or map before the
PlayerDisplayhas been added to the_playerDisplays.