Skip to content
This repository has been archived by the owner on Mar 17, 2023. It is now read-only.

chore: upgrade imagemin-webp to v7.0.0 #413

Merged

Conversation

adamstankiewicz
Copy link
Contributor

@adamstankiewicz adamstankiewicz commented Jan 4, 2022

Related to #412, this PR upgrades imagemin-webp from v6 to v7. Per the release notes, v7 changes it output format to ESM which necessitates the use of import instead of require, which can also be noted in the failing CI in the above linked PR from dependabot:

Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: /home/runner/work/image-webpack-loader/image-webpack-loader/node_modules/imagemin-webp/index.js
require() of ES modules is not supported.

After changing to import, the previously failing npm run test is now passing while using imagemin-webp@7.

This is required to upgrade/remove a transient dependency trim-newlines which currently has a "High" security vulnerability, causing Dependabot alerts across several repositories.

@adamstankiewicz adamstankiewicz changed the title chore: upgrade imaginemin-webp to v7.0.0 chore: upgrade imagemin-webp to v7.0.0 Jan 4, 2022
@macdiesel
Copy link

@tcoopman any chance you could merge this? We would like to get this high security vulnerability squashed ASAP.

Thanks,

Brian

@tcoopman tcoopman merged commit 5fc7670 into tcoopman:master Jan 11, 2022
@adamstankiewicz adamstankiewicz deleted the astankiewicz/upgrade-imagemin-webp-v7 branch January 11, 2022 12:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants