Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Pattern Type Filter in ACLs Panel Information for: Topics, Groups, Clusters and Transactional IDs #1115

Closed
javier-torres opened this issue Jun 9, 2022 · 8 comments
Closed

Show Pattern Type Filter in ACLs Panel Information for: Topics, Groups, Clusters and Transactional IDs #1115

javier-torres opened this issue Jun 9, 2022 · 8 comments
Assignees
@10xtechie
Labels
acl Kafka ACLS enhancement New feature or request ui Need an ui update

Comments

@javier-torres
Copy link

javier-torres commented Jun 9, 2022 •
edited
Loading

Hi,

We have working with AKHQ several months and we are very happy with the application, it´s fantastic!!

As we are using it every, we have been findind several little things to improve. Recently we have open and issue to show more information in ACLs panel how are: Cluster and TransactionalID. Now we believe that it would be quite interesting to show information for Pattern Type Filter in each resources as: Topics, Groups, Clusters and Transactional IDs.

Attached an image of what we have in mind that would be interesting to consult:

image

Thank you so much.
Javier Torres
@tchiotludo tchiotludo added enhancement New feature or request ui Need an ui update acl Kafka ACLS labels Jun 13, 2022
@tchiotludo
Copy link
Owner

it's will be nice, PR are welcome :)

@jheinitz
Copy link
Contributor

Hello!

Nice idea, but I'm just wondering why my ACLS screen for a given user only contains the tabs "Topics" and "Groups", but no "Cluster" and "Transactional Ids". Did you fake the screenshot or do I need to grant permissions for the user/group to see these acls? By the way, I'm using 0.21.0

Kind regards

Jens

@tchiotludo
Copy link
Owner

it's not release for now, you need to use the dev version for now

@javier-torres
Copy link
Author

javier-torres commented Jun 15, 2022 •
edited
Loading

Hi,

@jheinitz you must use dev image: tchiotludo/akhq:dev

When release success you need specify tchiotludo/akhq:<new_release>

Thank you

@10xtechie
Copy link
Contributor

10xtechie commented Jun 19, 2022 •
edited
Loading

@tchiotludo , @javier-torres ,
Is my understanding correct that a filter for Patter Type needs to be added to the top of each table under: Topics, Groups, Clusters, Transactional Id ?
If so, there seems to be quite a bit of work involved for this issue. However, I would be happy to take this on :)

@tchiotludo
Copy link
Owner

I understand the same @10xtechie, I assign you the issue, Thanks 👍

@javier-torres
Copy link
Author

Hi,
@10xtechie yes when you choose Topics, Groups, Clusters, Transactional Id you must visualize table with information for Pattern Type

@10xtechie
Copy link
Contributor

@tchiotludo, @javier-torres,
Thanks for your replies!! Could you please provide me with sample/dummy data and some instructions on how to populate Kafka with those data? It would be helpful to test the feature while developing it :)

10xtechie added a commit to 10xtechie/akhq that referenced this issue Jun 21, 2022
@10xtechie
issue tchiotludo#1115 adding Pattern Type to ACLs Panel Information
57b76e7
@10xtechie 10xtechie mentioned this issue Jun 25, 2022
Merged
12ushan added a commit to giffgaff/akhq that referenced this issue Nov 22, 2022
@12ushan @moremagic
@tooptoop4 @smasala @AnStrelnikov @marcellorego @10xtechie @ThomasSanson @tchiotludo @rdrck47 @rogerioefonseca @thomas-chauvet @erikgb @neeraj-singh47 @sam0r040 @Argonus @ali-1995 @alexvaque @itscaro @AdiWehrli @lucapette @tristanexsquare @meeraj257 @GnanaJeyam @owidder @HailToDodongo @raph-af @raphael-afanyan @alozano3 @ebrard
Pull from upstream 0.23 (#11)
e0db9cb 
* fix(topicdata): handle unsupported DescribeLogDirs  for MSK Serverless (tchiotludo#1113)

close tchiotludo#1112

* chore(deps): upgrade aws-msk-iam-auth to 1.1.4 to avoid vulnerability (tchiotludo#1114)

https://github.com/aws/aws-msk-iam-auth/releases/tag/v1.1.4 shows several fixes for CVEs

* chore(docs): add tui to usage list (tchiotludo#1118)

* chore(docs): update alt text for tui (tchiotludo#1119)

* chore(docs): add tui logo to public assets (tchiotludo#1120)

* feat(topicdata): adding serializer for protobuf schema registry (tchiotludo#1117)

* feat(topicdata): allow integer/long to be serialized as float/double when using AVRO schema. (tchiotludo#1123)

close tchiotludo#1122

* feat(ui): add pagination size of topic list (tchiotludo#1109)

relate tchiotludo#1051

* feat(acsl): add  Pattern Type to ACLs Panel Information (tchiotludo#1125)

close tchiotludo#1115

* fix(docker): run upgrade in order to reduce CVEs (tchiotludo#1134)

libssl1.1
dpkg
libldap-common

close tchiotludo#1132

* feat(docker): add healthcheck (tchiotludo#1136)


Co-authored-by: Ludovic DEHON <[email protected]>

* fix(ui): handle consumer group with slash (tchiotludo#1143)

close tchiotludo#1101

* Revert "chore(readme): add redpanda sponsors"

This reverts commit ab9a444.

* fix(helm): adding namespace to kubectl port-forward Helm Chart NOTES (tchiotludo#1171)

Co-authored-by: rogerio <[email protected]>

* fix(helm): correct port for port-forward is 8080 (tchiotludo#1178)

Fix port displayed at the end of the helm release.

It displays `{{ .Values.service.port }}` which is `80` per default, it should be `8080`.

* feat(docker): change upstream image from openjdk to eclipse-temurin (tchiotludo#1179)


Signed-off-by: Erik Godding Boye <[email protected]>

* fix(core): close consumer when returning null after calculating offset for newest sort (tchiotludo#1069)

fix a memory leak 

Co-authored-by: Neeraj.singh <[email protected]>

* fix(ui): load, display and store settings on settings screen if no settings have been stored yet (tchiotludo#1161)

Co-authored-by: David Müller <[email protected]>

* feat(docs): update vuepress to last versions

* chore(docs): add Fresha to whos using (tchiotludo#1111)

* chore(version): update to 0.22.0

* fix(ui): showing protobuf schema in versions tab crash (tchiotludo#1189)

Fixes tchiotludo#1188

* feat(docs): helm example with basic auth and aws msk (tchiotludo#1192)


Co-authored-by: Ludovic DEHON <[email protected]>

* feat(helm): add networkpolicy (tchiotludo#1193)

Signed-off-by: Quan TRAN <[email protected]>

* feat(helm): add configuration for readiness & livenessProbe

* chore(deps) add missing scala dependent modules (tchiotludo#1223)

* feat(docs): add a Kestra banner

* fix(topicdata): protection against tombstone message and headers

close tchiotludo#1210

* feat(webserver): add custom headers configuration (tchiotludo#1235)


Co-authored-by: Ludovic DEHON <[email protected]>

* chore(docs): fix typo (tchiotludo#1240)

* chore(cicd): update slack channel

* fix(ui): decimals are not parsed correctl (tchiotludo#1246)

replaced 'json-bigint' parser with 'lossless-json', this replacement allows for pretty-printing the json data, but still keeping the original values especially for floating numbers and bigints.

fix tchiotludo#1006

* core(deps): Updated micronaut to latest version (tchiotludo#1247)

and fixes to tests to have a successful build

close tchiotludo#1215

* fix(ui): Disabled edit access topic configs when role has reader mode (tchiotludo#1237)

close tchiotludo#1219

* fix(ui): encode groupId to allow '&' as part of the name of a consumer group (tchiotludo#1184)


relate to tchiotludo#1143

* feat(ui): faster topic-data search & sorting (tchiotludo#1209)


Co-authored-by: Max Bebök <[email protected]>

* feat(topicdata): added fix for incorrect datatype and missing fields in the json while producing to topic (tchiotludo#1233)

* feat(ui): Use `set INLINE_RUNTIME_CHUNK=false&& ` in react build. (tchiotludo#1238)

See also https://drag13.io/posts/react-inline-runtimer-chunk/index.html. This is to make _Content-Security-Policy_ work when `unsafe-inline` is not set.

Co-authored-by: Ludovic DEHON <[email protected]>

* fix(node):  fix nullpointer when trying to view cluster information in MSK Serverless (tchiotludo#1227)

close tchiotludo#1226

Co-authored-by: Ludovic DEHON <[email protected]>

* chore(deps): update all java deps

* feat(ui): optimze svgs with https://jakearchibald.github.io/svgomg/ (tchiotludo#1252)

In preparation for a React upgrade, see tchiotludo#1243

* feat(topicdata): support duplicate header keys (tchiotludo#1258)

close tchiotludo#1257 

Co-authored-by: rafanyan <[email protected]>

* chore(deps): update codeql actions to supported version (tchiotludo#1253)

See
https://github.blog/changelog/2022-04-27-code-scanning-deprecation-of-codeql-action-v1/
for context

* chore(version): update to 0.23.0

* feat(ui): update node to the latest lts version (tchiotludo#1251)

* Update node to the latest LTS version
* Replace node-sass with sass
* Also use the correct version of react-test-renderer.
* Update react scripts so we don't use insecure hashing functions
* Do not check eslint for production build

See tchiotludo#1243 for more information.

* fix(topicdata): fix null key and value (tchiotludo#1261)

Co-authored-by: alozano3 <[email protected]>

* feat(ui): fix eslint warnings (tchiotludo#1254)


Co-authored-by: Ludovic DEHON <[email protected]>

* fix(topci): create topics with configuration in one call (tchiotludo#1273)

close tchiotludo#1272

Signed-off-by: Erik Godding Boye <[email protected]>
Signed-off-by: Quan TRAN <[email protected]>
Co-authored-by: Mitsuaki Ito <[email protected]>
Co-authored-by: tooptoop4 <[email protected]>
Co-authored-by: Steven Masala <[email protected]>
Co-authored-by: Steven Masala <[email protected]>
Co-authored-by: Andrei Strelnikov <[email protected]>
Co-authored-by: Marcello <[email protected]>
Co-authored-by: 10xtechie <[email protected]>
Co-authored-by: ThomasSanson <[email protected]>
Co-authored-by: Ludovic DEHON <[email protected]>
Co-authored-by: Rodrigo Rodriguez Ramos <[email protected]>
Co-authored-by: Rogério Fonseca <[email protected]>
Co-authored-by: rogerio <[email protected]>
Co-authored-by: Thomas <[email protected]>
Co-authored-by: Erik Godding Boye <[email protected]>
Co-authored-by: neeraj-singh47 <[email protected]>
Co-authored-by: Neeraj.singh <[email protected]>
Co-authored-by: sam0r040 <[email protected]>
Co-authored-by: David Müller <[email protected]>
Co-authored-by: Piotr Rybarczyk <[email protected]>
Co-authored-by: Ali Akhtari <[email protected]>
Co-authored-by: Alex Vaque <[email protected]>
Co-authored-by: Quan TRAN <[email protected]>
Co-authored-by: Adi Wehrli <[email protected]>
Co-authored-by: lucapette <[email protected]>
Co-authored-by: tristanessquare <[email protected]>
Co-authored-by: meeraj257 <[email protected]>
Co-authored-by: Gnana_Jeyam <[email protected]>
Co-authored-by: owidder <[email protected]>
Co-authored-by: Stuff is on GitLab <[email protected]>
Co-authored-by: Max Bebök <[email protected]>
Co-authored-by: Raphael <[email protected]>
Co-authored-by: rafanyan <[email protected]>
Co-authored-by: Albert <[email protected]>
Co-authored-by: alozano3 <[email protected]>
Co-authored-by: Emmanuel <[email protected]>
@tchiotludo tchiotludo moved this to Done in Backlog Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@10xtechie 10xtechie

Labels
acl Kafka ACLS enhancement New feature or request ui Need an ui update
Projects
Backlog
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tchiotludo @jheinitz @javier-torres @10xtechie