Minimal ui changes and config #7

celiacheff · 2022-03-21T14:24:05Z

Resolve tchapgouv/matrix-react-sdk-v4#12

Basic UI changes:

Some colors to match somewhat Tchap.
Some features we want to hide:

"UIFeature.voip": false, -> No VoIP for now in Tchap
"UIFeature.shareSocial": false -> Not for Tchap
"disable_custom_urls": true, -> User can't choose his server
"disable_guests": true, -> No guests in Tchap

This PR currently has no changelog labels, so will not be included in changelogs.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

celiacheff · 2022-03-22T11:48:21Z

Possible next smalls improvements:
color on login/connect page -> need manual change on web repo, could PR on Element
Change BG image -> need manual change on web repo, could PR on Element
Header -> need manual change on react-dsk repo, could PR on Element

More improvements like hiding features are also available via custom perms in react-sdk

celiacheff · 2022-03-22T11:49:19Z

Also, don't forget to update the config.json

estellecomment · 2022-03-22T13:40:59Z

config.sample.json

    "showLabsSettings": false,
    "features": { },
    "default_federate": true,
-    "default_theme": "light",
+    "default_theme": "custom-Tchap",


on peut l'appeler juste Tchap ?

Nope, contrainte technique pour éviter les conflits de noms

Mais ça apparait comme "Tchap" dans la sélection

estellecomment · 2022-03-22T13:44:33Z

scripts/make-icons.sh

@@ -17,7 +17,7 @@ set -x

 tmpdir=`mktemp -d 2>/dev/null || mktemp -d -t 'icontmp'`

-for i in 1024 512 310 256 192 180 152 150 144 128 120 114 96 76 72 70 64 60 57 48 36 32 24 16
+for i in 1024 512 310 300 256 192 180 152 150 144 128 120 114 96 88 76 72 70 64 60 57 50 48 44 36 32 24 16


Est-ce que ca vaudrait pas le coup de faire une copie du script, make-tchap-icons.sh, vu qu'il y a plein de changements ?

Ce script est pas mis à jour depuis perpet, ils l'utilisent certainement plus à mon avis.Je peux aussi ne pas le commit du tout, c'est juste un helper à utiliser une fois

estellecomment · 2022-03-22T13:45:07Z

scripts/make-icons.sh

@@ -17,7 +17,7 @@ set -x

 tmpdir=`mktemp -d 2>/dev/null || mktemp -d -t 'icontmp'`

-for i in 1024 512 310 256 192 180 152 150 144 128 120 114 96 76 72 70 64 60 57 48 36 32 24 16
+for i in 1024 512 310 300 256 192 180 152 150 144 128 120 114 96 88 76 72 70 64 60 57 50 48 44 36 32 24 16


Ca serait bien de documenter les modifications, vite fait : ya des parties enlevées et rajoutées qui sont un peu mysterieuses pour moi.

C'est juste les tailles des icones générées. Il y a des tailles qui manquent par rapport aux icones présentes dans la version actuelle d'element et j'avais pas envie de les faire à la main. En gros le script génère plein de taille d'images, et selectionne ensuite les bonnes pour les renommer.

J'ai viré des parties qui buguent, parce qu'on à pas de build electron

estellecomment · 2022-03-22T14:08:39Z

Good job !

Things that are still missing (feel free to do them in a separate PR. In this case please document them in the issue) :

When no room is open : http://localhost:8080/#/home : logo is missing
Before logging in, there is no theming (welcome page, login page, register page).
When searching :
While the tab loads, the tab name is "Element", then when the customisation loads, the tab name changes to "Tchap". That looks bad, and might be tricky to fix... :/ We can drop it for now (maybe file it as a separate issue...)

celiacheff · 2022-03-22T15:44:59Z

Good job !

Things that are still missing (feel free to do them in a separate PR. In this case please document them in the issue) :
* When no room is open : http://localhost:8080/#/home : logo is missing
  ![image](https://user-images.githubusercontent.com/911434/159498745-3192e849-c578-489a-8607-da24441c7b0a.png)

I have the right logo, I'll find a way to reproduce.

* Before logging in, there is no theming (welcome page, login page, register page).

Yeah I commented about this above: #issuecomment-1075078566

* When searching :
  ![image](https://user-images.githubusercontent.com/911434/159499497-174391ef-4078-4e14-a2c0-543907e1f9d1.png)

* While the tab loads, the tab name is "Element", then when the customisation loads, the tab name changes to "Tchap". That looks bad, and might be tricky to fix... :/ We can drop it for now (maybe file it as a separate issue...)

Will check that.

estellecomment

Tested locally (no review apps yet)

Nice job !!

estellecomment · 2022-03-23T10:19:17Z

config.sample.json

        },
        "m.identity_server": {
            "base_url": "https://matrix.i.tchap.gouv.fr"
        }
    },
-    "disable_custom_urls": false,
-    "disable_guests": false,
+    "disable_custom_urls": true,


Suggested change

"disable_custom_urls": true,

"disable_custom_urls": false,

On a besoin de changer de homeserver parce qu'il y en a plusieurs

Yes, c'était vraiment configuré pour un PoC, avec volonté de changer plus tard

estellecomment · 2022-03-23T10:25:46Z

res/welcome.html

@@ -170,9 +170,9 @@

 <div class="mx_Parent">
    <a href="https://element.io" target="_blank" rel="noopener">
-        <img src="welcome/images/logo.svg" alt="" class="mx_Logo"/>
+        <img src="themes/element/img/logos/tchap-logo.svg" alt="" class="mx_Logo"/>


on peut mettre ce logo dans un dossier tchap plutot que dans le dossier element ? /res/themes/tchap

Pas de pb, juste dommage qu'on ai pas un settings pour choisir un dossier directement

estellecomment · 2022-03-23T10:28:05Z

src/i18n/strings/en_EN.json

@@ -25,7 +25,7 @@
    "I understand the risks and wish to continue": "I understand the risks and wish to continue",
    "Go to element.io": "Go to element.io",
    "Failed to start": "Failed to start",
-    "Welcome to Element": "Welcome to Element",
+    "Welcome to Tchap": "Welcome to Tchap",


j'ai réfléchi, pour l'organisation des translations, est-ce qu'on peut mettre tous nos changements en bas du fichier, pour keep track ? (rappelle-toi les problemes de merge sur v2...)

Ici je propose de rajouter "Welcome to Tchap" en bas et de laisser "Welcome to Element" tel quel.

The point is it should be a var here, like it is done elsewhere. I'll PR this to Element later

estellecomment · 2022-03-23T10:28:10Z

src/i18n/strings/fr.json

@@ -3,7 +3,7 @@
    "powered by Matrix": "propulsé par Matrix",
    "Unknown device": "Appareil inconnu",
    "You need to be using HTTPS to place a screen-sharing call.": "Vous devez utiliser HTTPS pour effectuer un appel avec partage d’écran.",
-    "Welcome to Element": "Bienvenue sur Element",
+    "Welcome to Tchap": "Bienvenue sur Tchap",


…6953..df47422a082 df47422a082 Merge pull request #7 from tchapgouv/upgrade-v3.100.0-rc.0 79a390fc81f feat(merge): merge conflict with v3.100.0-rc.0, decrypt message, roomtopic, package.json, accessiblebutton 96909be77b4 Merge tag 'v3.100.0-rc.0' into tchap d84bcbc v3.100.0-rc.0 402e5db Upgrade dependency to [email protected] 77a7245 Tooltip: Improve the accessibility of the composer and the rich text editor (#12459) 6e31f69 Reuse single PlaybackWorker between Playback instances (#12520) 51f7156 Fix Netlify deployments not publishing when expected (#12521) f028188 Fix well-known lookup for sliding sync labs check (#12519) d0b30d1 Allow explicit configuration of OIDC dynamic registration metadata (#12514) 357f882 Move to `AccessibleTooltipButton` in messages (#12487) 7a4ac57 Disable the login overwriting test (#12507) b283b18 Fix flakiness in playwright tests (#12512) cc69589 Fix `element-desktop-ssoid being` included in OIDC Authorization call (#12495) ed7a21a Remove spurious type casts and avoid deprecated symbols (#12513) 113299d [create-pull-request] automated change (#12515) 4ed6da4 Remove old pre-join UTD logic (#12464) 948435c Collapse UserSettings tabs to just icons on narrow screens (#12505) c6f6f1d Fix Playwright github reporter to run in the pull_request context once more (#12509) eee0b2a Add room topic to right panel room info (#12503) 3889392 Add note about MSC3886, MSC3903 and MSC3906 being closed (#12496) 3109b97 Fix beta notifications reconciliation for intentional mentions push rules (#12510) 706c4b7 Use h tag for widget title instead of b tag (#12504) 51a5436 [create-pull-request] automated change (#12502) c8fa831fd52 feat(email-settings): add caption detail for email notif setting d1eab0a Reset matrix-js-sdk back to develop branch 2bf15d8 Resetting package fields for development e1d7b1c Merge branch 'master' into develop 462b0ff v3.99.0 79c79f6 Upgrade dependency to [email protected] 580bb55 OIDC: pass `id_token` via `id_token_hint` on Manage Account interaction (#12499) e2310e6 Update end-to-end-tests.yaml febb60e Tooltip: improve accessibility for call and voice messages (#12489) caef3c1 Tooltip: improve accessibility in room (#12493) 18ef971 Move the active tab in user settings to the dialog title (#12481) 0e6fe3cf765 feat(voip): hide video button when feature not active on homeserver f8e040a Tooltip: Remove extra data attribute (#12483) c121167 fix avatar stretched on 1:1 call (#12494) f29823c Check native sliding sync support against an unstable feature flag (#12498) 9684dd5 Make TabbedView a controlled component (#12480) 2f3c84f Tooltip: improve accessibility of spaces (#12497) 050f617 Convert tabbedview to functional component (#12478) 95ee297 Tooltip: improve accessibility of the right panel (#12490) 3059b5b Use OPTIONS for sliding sync detection poke (#12492) d25d529 Extract functions for service worker usage, and add initial MSC3916 playwright test (when supported) (#12414) a34dbbc v3.99.0-rc.1 1173180 [Backport staging] TAC: Fix accessibility issue when the Release announcement is displayed (#12484) c152bfd [Backport staging] TAC: Close Release Announcement when TAC button is clicked (#12485) 374cee9 Fix flaky jest tests (#12486) 7193d4c TAC: Fix accessibility issue when the Release announcement is displayed (#12482) 6a3741b TAC: Close Release Announcement when TAC button is clicked (#12475) ad7f626 Do not render tooltip when RA is displayed on TAC (#12472) 5dc3ad5 Improve comments and types in MatrixClientPeg (#12477) 74e7195 Update react-types (#11815) 0914998 Update dependency posthog-js to v1.130.1 (#12479) d66cd51 [create-pull-request] automated change (#12476) 906c9dd Convert UserSettings to functional component (#12474) bb4f575 MSC3575 (Sliding Sync) add well-known proxy support (#12307) 641a20c Prepare for OIDC QR Login PR (#12463) 1c79bbb Update dependency typescript to v5.4.5 (#12422) dafd9c2 Update all non-major dependencies (#12468) 3ca7996 Update dependency stylelint to v16.4.0 (#12470) 016533b Update dependency @sentry/browser to v7.112.2 (#12469) 6504cf5 Update typescript-eslint monorepo to v7.7.1 (#12467) c2e6325 Update babel monorepo to v7.24.5 (#12465) 9a0d071 Update dependency eslint-plugin-react-hooks to v4.6.2 (#12466) dbedeca Update matrix-org (#12426) d813457 v3.99.0-rc.0 a6f7aa6 Upgrade dependency to [email protected] f648f00 Update end-to-end-tests.yaml 2df946b Tooltip: Use `AccessibleButton` in `RovingAccessibleTooltipButton` (#12458) 3634e66 Update end-to-end-tests.yaml 16a01d8 Update end-to-end-tests.yaml a2f79895cd8 Merge subtree commit 'f93067358d0d82e4dec408cfa822cbc379ec02fd' into upgrade-element-1.11.65 9aeaa38 Tooltip: Use `AccessibleButton` in dialogs (#12460) 44e2a6d Tooltip: Use `AccessibleButton` in reusable elements (#12461) d5bf102 Use a different error message for UTDs when you weren't in the room. (#12453) 9cc362e Update netlify.yaml 281916f Take the Threads Activity Centre out of labs (#12439) 0138e175d25 Merge pull request #978 from tchapgouv/795-onboarding-enable-secure-backup 02e7fb3 Simplify Playwright CI (#12457) 45132ec MenuItem: fix caption usage (#12455) 264e202 Add extra attribute to `AccessibleButton` (#12456) bd7ce7c Expected UTDs: use a different message for UTDs sent before login (#12391) 700b395 Add `Tooltip` to `AccessibleButton` (#12443) 5c4ebff6167 feat(onboarding-enable-secure-backup): reorder onboading and add secure backup ac6d9369692 fix(rageshake): reallow customapp field 644bf78 Show the local echo in previews (#12451) 158e111 Fixed the drag and drop of X ##27186 (#12450) 33c56e5 Reset matrix-js-sdk back to develop branch 5f9edc6 Resetting package fields for development c778b0f Merge branch 'master' into develop 427be43 Add analytics to activity toggles (#12418) 6dd6a76 Decrypt events in reverse order without copying the array (#12445) cc7edad Move the TAC to above the button (#12438) 198b975 [create-pull-request] automated change (#12440) 2c848d7 Merge pull request #12416 from matrix-org/florianduros/tooltip-update c97a374 Merge branch 'develop' into florianduros/tooltip-update fb989ee Update compound web bf0fed5 Use focus instead of hover d402b52 Collect decryption failure translations together (#12436) 48a3a09 Merge branch 'refs/heads/develop' into florianduros/tooltip-update 0e65a5a Update dependency posthog-js to v1.126.0 (#12437) 04b5b58 Expected UTDs: report a different Posthog code (#12389) 6cec2bb Use the same logic in prevews as the timeline to hide events that should be hidden (#12434) 9b5d471 Merge branch 'develop' into florianduros/tooltip-update 1ace170 [create-pull-request] automated change (#12435) 04a2191 fix selector so maths support doesn't mangle divs (#12433) 193237f Update dependency eslint-plugin-jest to v28 (#12431) 3e12cd9 Update all non-major dependencies (#12423) 8d22cab Update dependency eslint-plugin-unicorn to v52 (#12432) b1bd46c Update typescript-eslint monorepo to v7.6.0 (#12427) 68b43f2 Update dependency @sentry/browser to v7.110.0 (#12425) e8fc2cf Update dependency @playwright/test to v1.43.1 (#12424) 30b864f Update dependency @types/node to v18.19.31 (#12421) ceab73a Update babel monorepo to v7.24.4 (#12420) e53b175 Merge branch 'develop' into florianduros/tooltip-update 6c9d8e5 Fix e2e test c6325e2 Update tests 89b1c2f Update `@vector-im/compound-web` to `v4.0.1` 95c0ff9 Fix typing issues 30d60bf Update compound to v4.0.0` 79cbfaf Merge branch 'refs/heads/develop' into florianduros/tooltip-update 5354e6e Use new compound tooltip git-subtree-dir: linked-dependencies/matrix-react-sdk git-subtree-split: df47422a082658ff90a95fd23a938a25b19c875f

…9d90..892a9e658e8 892a9e658e8 Merge pull request #11 from tchapgouv/upgrade-v3.112.0 7cf9e10e21d Fix merge conflict v3.112.0 ebd1e11d284 Merge tag 'v3.112.0' into upgrade-v3.112.0 933885386ed v3.112.0 e4ed18297cf Upgrade dependency to [email protected] 3687ee382dd test(sso): add test for email precheck, registration and welcome component b32de09a709 v3.112.0-rc.0 08b3912de0f Upgrade dependency to [email protected] dd405ea582d Merge remote-tracking branch 'origin/develop' into staging f33e802 Fix untranslated keys being rendered in `/help` dialog (#90) cd850f5be67 v3.111.0 059db4db1b8 Merge pull request #106 from element-hq/backport-95-to-staging d30645f9084 Allow joining calls and video rooms without enabling the labs flags (#95) 39a0f6e Remove ts-ignores where no longer necessary (#89) c10bc6c7168 feat(sso): add feature flag to active sso flow 36fae00 Change device isolation mode to set `errorOnVerifiedUserProblems` to `false` (#104) 33c900e Remove right panel toggling behaviour on room header buttons (#100) 81bb56a Simplify Jest runs in CI to share failures with merge queue (#103) fe402e2 Fix flaky mobile registration tests (#102) 0b3b499 Fix label sync (#101) bd793a0 Allow joining calls and video rooms without enabling the labs flags (#95) 4f39164 Ensure timeline search results are visible even in video rooms (#96) f28f1d9 Improve error display for messages sent from insecure devices (#93) be2c1fc Add labs option to exclude unverified devices (#92) 78cca0201a9 feat(sso): remove existing sso buttons 8962e8c Improve contrast for timestamps, date separators & spotlight trigger (#91) ef9e310 Pop right panel timeline when unmaximising widget to avoid double timeline (#94) fed6c34d440 feat(sso): add email domain precheck sso flow 81192f6 Update dependency typescript to v5.6.2 (#71) 34d1875 Open room settings on room header avatar click (#88) 3f67819 Merge pull request #41 from element-hq/t3chguy/wat/230.1 e6404da Update test assertions 9e4348e Update test assertions dd7479a Merge branch 'develop' of github.com:element-hq/matrix-react-sdk into t3chguy/wat/230.1 ad94c39 Fix accessible label on left panel spotlight trigger (#87) 2e895da Crypto: fix display of device key (#86) df9d81398ab v3.110.0 1d5d0cc835f Upgrade dependency to [email protected] 3c267f9 Update snapshots 3620c5a Merge branch 'develop' into t3chguy/wat/230.1 a1bdcee Update dependency @types/node to v18.19.50 (#65) ef1d4f6 Grant Element Call widget capabilities for "raise hand" feature (#82) 47a9377 Update dependency @types/react to v17.0.82 (#66) 9aa09d4 Maybe fix flakey AddRemoveThreepid test (#81) d56b9ed Update dependency eslint to v8.57.1 (#68) a248788 Update peter-evans/create-pull-request digest to 5e91468 (#64) 1f55710 Mobile registration optimizations and tests (#62) 4be5338 Update dependency @sentry/browser to v8.30.0 (#69) b055908 Update dependency css-tree to v3 (#74) d4c942d Update playwright monorepo to v1.47.1 (#73) ed7e02a Update dependency stylelint-scss to v6.6.0 (#70) 5058d66 Update Sibz/github-status-action digest to faaa4d9 (#63) cf8fe20 Update dependency express to v4.20.0 [SECURITY] (#26) fe65702 Update to use non deprecated methods to decode recovery key (#54) 490746e Update to use non deprecated methods to derive key from passphrase (#55) 73843e5fe6b v3.110.0-rc.1 4776f87 Ignore chat effect when older than 48h (#48) 0cc0ebe Replace old reference of `matrix-org/matrix-react-sdk` by `element-hq/matrix-react-sdk` (#60) 3dd223c Also add NPM_TOKEN (#57) 1e76313 Playwright: factor out some common code (#49) 154bf33 Manually clear orphaned recaptcha challenge overlay in android webviews (#53) d04d611f1e8 v3.110.0-rc.0 0bbed85 Pass bot token through explicitly (#56) 6eb332f26d5 Upgrade dependency to [email protected] 49d84a6b0f9 Merge remote-tracking branch 'origin/develop' into staging 7feb5a0 Merge branch 'develop' into t3chguy/wat/230.1 13e67ae Add Release announcement for the pinning message list (#46) 1058af6 Playwright test for E2E messages from deleted devices (#47) 78ac691f50b feat(settings): remove generalusersettingtab and use accountusersetting tabs, hide personal info c24661f [create-pull-request] automated change (#45) 5985277 Unlabs feature pinning (#22) 74885c9 Merge pull request #42 from element-hq/langleyd/mobile_registeration 20a4f0a Enforce config setting 3d89fc3 Merge branch 'develop' of https://github.com/element-hq/matrix-react-sdk into langleyd/mobile_registeration 62d66f9 Remove accidental paste 0716434 Allow hs_url as param on mobile_register a89f61a Add error text and title with server name 9426fec Fix timeout type (#40) be59791 Add support for `org.matrix.cross_signing_reset` UIA stage flow (#34) 8044ce4 Fix tests b505828 update test to work with newer Rust crypto (#32) 0244aae use window.dispatchEvent a6dec86 Add mobile registration and dispatch event for mobile postmessage dance a6e98b0 Use `strong` over `b` for improved a11y semantics 6b384fe Fix huge usage bandwidth and performance issue of pinned message banner. (#37) 5740bdb [create-pull-request] automated change (#39) 0e8cd5b [create-pull-request] automated change (#38) eae9d9e Add timezone to user profile (#20) f317763 Reverse pinned message list (#19) 85b4f17 [create-pull-request] automated change (#33) a701e3a Add config option to force verification (#29) 75918f5 Reduce pinned message banner size (#28) 433c14e Log clearer errors when picklekey goes missing (#27) d337fba Add labels file (#21) 03004a5 Change settings to true by default (#25) 07125f5 Remove release announcement of new header (#23) ccb1a61 [create-pull-request] automated change (#24) 51495e7 Remove pinned message list screenshot which are flacky (#17) 24fe2f2 [create-pull-request] automated change (#18) 491f0cd Change license (#13) 4382c67 Change org to element-hq (#7) 461da98 Merge pull request #10 from element-hq/dbkr/changelog_repos e8c0b65 Merge branch 'develop' into dbkr/changelog_repos 6dd67b3 Merge pull request #11 from element-hq/dbkr/update_org_sonar c26ce7a Merge branch 'develop' into dbkr/changelog_repos 3a42d2a Merge branch 'develop' into dbkr/update_org_sonar d4771dd Merge pull request #3 from element-hq/dbkr/codeowners 58331fb Merge pull request #15 from element-hq/actions/localazy-download 0acc7dd [create-pull-request] automated change 272fd75 remove meangingless change 9fb871c poke the CI caa6f26 Merge pull request #14 from element-hq/actions/playwright-image-updates 92b3eb5 [create-pull-request] automated change deeeffa Update project key too 35f96b4 Update GH org in the sonar config file 9601be5 Update tests f8da257 Update repos for changelog fetching 774222f Update codeowners to element-hq teams 78059e1 Merge pull request #1 from element-hq/actions/playwright-image-updates eb14223 [create-pull-request] automated change 33791ca Merge pull request #12965 from matrix-org/florianduros/pinned-messages/analytics-event 08d1b6c Add analytics event for pinned messages bce710e Upgrade `@matrix-org/analytics-events` to `0.25.0` 5bfbca9 Migrate all pinning checks and actions into `PinningUtils` (#12964) 2639923 Update browserslist (#12953) 6490742 Log phases in the verification process (#12963) cdffbdb Add error handling for room publish toggle (#12941) 1e3320d Pinned message list: prevent sender name to overflow pinned event tile (#12947) ab1e28b Compute with of content of pinned event tile (#12951) 60fe70b Add a prefix to file, poll, image, video and audio in the pinned message banner (#12950) 9d8c5b6 Update dependency @testing-library/jest-dom to v6.5.0 (#12957) dbc8c9f Update peter-evans/create-pull-request action to v7 (#12960) 33404e4 Update stylelint (#12958) df82c8a Update dependency @sentry/browser to v8.27.0 (#12956) 892b297 Update babel monorepo (#12955) 4769985 Update dependency @types/node to v18.19.47 (#12954) 8f22eb64432 v3.109.0-rc.0 9c233ef5db3 Upgrade dependency to [email protected] 6bfdb3e Fix read receipt animation (#12923) 5ff3fd6 [create-pull-request] automated change (#12949) 579cb6b Update to 2.37.9 (#12943) f033b64 Display the indicator even with one message in pinned message banner (#12946) 41686bb Always display last pinned message on the banner (#12945) 1ac533e Don't emit decrypted event for the banner (#12944) ae15bbe Allow user to set timezone (#12775) acc7342 [create-pull-request] automated change (#12942) 3d41f5b [create-pull-request] automated change (#12938) 13ec19c Sort the pinning message list in the same order than the banner (#12937) 19f8b44 Implement download_file in widget driver (#12931) 2a450c0 Add `allowImportingTsExtensions` to tsconfig (#12939) d16ab09 Display pinned messages on a banner at the top of a room (#12917) 8b2ded8 [create-pull-request] automated change (#12935) 6fb8f6e Update all non-major dependencies (#12909) c6922c9 Fix reply message truncation on 2 lines (#12929) ea3c5cf Fix pin/unpin slowness and non refresh from the message action bar (#12934) 43941ef Install deja-vu font in docker image (#12932) 71c31bb [create-pull-request] automated change (#12926) 8421022 Rename all the slow reporter stuff to cjs (#12933) 5b91dd8 Reset matrix-js-sdk back to develop branch e66807e Merge branch 'master' into develop 30f84cd Update playwright image (#12930) f0a75d8 Add a config option to control the default widget container height (#12893) e599428 Ignore desktop for minimum browser support. (#12928) 1b70b22 Update typescript-eslint monorepo to v7.18.0 (#12924) 8381e13 Update stylelint (#12922) 5a9d7ba Remove unused CryptoCallbacks implementations (#12919) 69da175 Update babel monorepo (#12920) 0848237 Update dependency @types/sanitize-html to v2.13.0 (#12921) 135d94c Update playwright monorepo to v1.46.1 (#12918) 670ed81 Update dependency @sentry/browser to v8.26.0 (#12915) 35fb068 Update dependency axe-core to v4.10.0 (#12916) 9671545 Update dependency eslint-plugin-unicorn to v55 (#12913) 5e56ce7 Update dependency husky to v9 (#12914) 70665d3 RTE drafts (#12674) fdc5acd Update dependency @types/react-transition-group to v4.4.11 (#12912) 72d5659 Update dependency @types/node to v18.19.44 (#12911) 2768b9c Set entrypoints to use ./lib rather than ./src (#12906) a7e907e Add thread information in pinned message list (#12902) 3d80eff Add Pin/Unpin action in quick access of the message action bar (#12897) 4064db1 [create-pull-request] automated change (#12907) 933a9c1 Rename prettier config file to .cjs (#12903) git-subtree-dir: linked-dependencies/matrix-react-sdk git-subtree-split: 892a9e658e8a3f6fd225d2104b0e5001cd12ad7f

celiacheff requested a review from estellecomment March 22, 2022 11:48

estellecomment approved these changes Mar 22, 2022

View reviewed changes

celiacheff added 2 commits March 22, 2022 16:36

Minimal ui changes and config

9dfc11b

Replacing logos

a0cb207

Fix Tchap name in various places, some missing logos

33d325d

celiacheff force-pushed the feat/minimal_branding_and_config branch from 09076aa to 33d325d Compare March 22, 2022 17:05

estellecomment approved these changes Mar 23, 2022

View reviewed changes

Latests feedback

e25c545

celiacheff merged commit da38d1a into develop_tchap Mar 23, 2022

celiacheff deleted the feat/minimal_branding_and_config branch March 23, 2022 11:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Minimal ui changes and config #7

Minimal ui changes and config #7

celiacheff commented Mar 21, 2022 •

edited by github-actions bot

Loading

celiacheff commented Mar 22, 2022

celiacheff commented Mar 22, 2022

estellecomment Mar 22, 2022

celiacheff Mar 22, 2022

celiacheff Mar 22, 2022

estellecomment Mar 22, 2022

celiacheff Mar 22, 2022

estellecomment Mar 22, 2022

celiacheff Mar 22, 2022

celiacheff Mar 22, 2022

estellecomment commented Mar 22, 2022

celiacheff commented Mar 22, 2022

estellecomment left a comment

estellecomment Mar 23, 2022

celiacheff Mar 23, 2022

estellecomment Mar 23, 2022

celiacheff Mar 23, 2022

estellecomment Mar 23, 2022

celiacheff Mar 23, 2022

celiacheff Mar 23, 2022

estellecomment Mar 23, 2022

celiacheff Mar 23, 2022

Minimal ui changes and config #7

Minimal ui changes and config #7

Conversation

celiacheff commented Mar 21, 2022 • edited by github-actions bot Loading

celiacheff commented Mar 22, 2022

celiacheff commented Mar 22, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

estellecomment commented Mar 22, 2022

celiacheff commented Mar 22, 2022

estellecomment left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

celiacheff commented Mar 21, 2022 •

edited by github-actions bot

Loading