Skip to content

Commit

Permalink
Remove "sys isn't exported yet" phrase
Browse files Browse the repository at this point in the history
The oldest occurence is from 9e224c2bf18ebf8f871efb2e1aba43ed7970ebb7,
which is from the pre-1.0 days. In the years since then, std::sys still
hasn't been exported, and the last attempt was met with strong criticism:
rust-lang/rust#97151

Thus, removing the "yet" part makes a lot of sense.
  • Loading branch information
est31 committed May 30, 2022
1 parent 91c3d5b commit aea9943
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion std/src/sys/unix/locks/pthread_mutex.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ pub unsafe fn raw(m: &Mutex) -> *mut libc::pthread_mutex_t {
unsafe impl Send for Mutex {}
unsafe impl Sync for Mutex {}

#[allow(dead_code)] // sys isn't exported yet
impl Mutex {
pub const fn new() -> Mutex {
// Might be moved to a different address, so it is better to avoid
Expand Down
2 changes: 1 addition & 1 deletion std/src/sys_common/thread_local_dtor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
//! or implement something more efficient.

#![unstable(feature = "thread_local_internals", issue = "none")]
#![allow(dead_code)] // sys isn't exported yet
#![allow(dead_code)]

use crate::ptr;
use crate::sys_common::thread_local_key::StaticKey;
Expand Down
2 changes: 1 addition & 1 deletion std/src/sys_common/thread_local_key.rs
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@

#![allow(non_camel_case_types)]
#![unstable(feature = "thread_local_internals", issue = "none")]
#![allow(dead_code)] // sys isn't exported yet
#![allow(dead_code)]

#[cfg(test)]
mod tests;
Expand Down

0 comments on commit aea9943

Please sign in to comment.