Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Test TypedArray's [[Set]] internal method with altered receiver"" #4200

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Aug 16, 2024

Reverts #2975

In #2957, @rwaldron requested a new PR to be made with these tests; that never seems to have happened.

@Ms2ger Ms2ger requested a review from a team as a code owner August 16, 2024 12:58
@ptomato
Copy link
Contributor

ptomato commented Aug 16, 2024

Very impressive archeology 😄

Copy link
Contributor Author

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't approve, but I reviewed these pretty carefully and I think they're correct

Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rubberstamp it then.

@Ms2ger Ms2ger merged commit 941813e into main Aug 16, 2024
8 checks passed
@Ms2ger Ms2ger deleted the revert-2975-revert-2957-typed-array-set-altered-receiver branch August 16, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants