More tests for duplicate named capturing groups #3706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @bakkot |
bakkot
approved these changes
Oct 29, 2022
Ms2ger
approved these changes
Nov 2, 2022
Parse-time syntax for RegExp literals is already tested. These two files test runtime RegExp compilation, with respect to duplicate named capture groups. See: tc39#3704
Each named capturing group should count as its own parenthesized capturing group, even if it has the same name as another group. So, some of these expectations were missing `undefined` array elements for the variant of the `x` capturing group that didn't match. In the other expectations, we forgot to take into account that the backreference is not inside a capturing group, so the group match should not have doubled letters in it.
These tests should cover the full functionality of the .groups object (and the .indices.groups object, in the case of the /d flag) for RegExp.p.exec and String.p.match: - Matched DNCG has a result - Unmatched DNCG is present and undefined - DNCG matched in previous iteration but not in current iteration is treated as unmatched - Iteration order of properties corresponds with source order See: tc39#3704
Ms2ger
force-pushed
the
duplicate-named-capturing-groups
branch
from
5a98bc5 to
991097c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3704. This covers the first and third tables in that issue: syntax tests, and tests covering the functionality of the
.groupsand.indices.groupsobjects.