Sync test of Temporal.Calendar.p*.fields to 1750 #3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ms2ger
previously approved these changes
Sep 9, 2021
test/built-ins/Temporal/Calendar/prototype/fields/long-input.js
Outdated
Show resolved
Hide resolved
test/built-ins/Temporal/Calendar/prototype/fields/long-input.js
Outdated
Show resolved
Hide resolved
test/built-ins/Temporal/Calendar/prototype/fields/repeated-throw.js
Outdated
Show resolved
Hide resolved
|
This cannot be merged until there are affirmatives from @ptomato @Ms2ger and @jugglinmike |
jugglinmike
reviewed
Sep 10, 2021
test/built-ins/Temporal/Calendar/prototype/fields/long-input.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Ms2ger <[email protected]>
Co-authored-by: Ms2ger <[email protected]>
…ow.js Co-authored-by: Ms2ger <[email protected]>
Co-authored-by: Ms2ger <[email protected]>
Co-authored-by: Ms2ger <[email protected]>
|
PTAL |
Ms2ger
previously approved these changes
Sep 13, 2021
test/built-ins/Temporal/Calendar/prototype/fields/long-input.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Ms2ger <[email protected]>
ptomato
previously approved these changes
Sep 13, 2021
test/built-ins/Temporal/Calendar/prototype/fields/repeated-throw.js
Outdated
Show resolved
Hide resolved
|
@ptomato PTAL |
ptomato
previously approved these changes
Sep 13, 2021
make sure the validation does not happen after the looping the generator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the test to sycn with tc39/proposal-temporal#1750 and add more tests for Temporal.Calendar.prototype.fields