Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Temporal.Instant.p*.subtract #3076

Closed
wants to merge 1 commit into from
Closed

Add tests for Temporal.Instant.p*.subtract #3076

wants to merge 1 commit into from

Conversation

FrankYFTang
Copy link
Contributor

ptomato
ptomato reviewed Aug 6, 2021
View reviewed changes
test/built-ins/Temporal/Instant/prototype/subtract/throw-range-error-from-AddInstant.js
@@ -0,0 +1,21 @@
// Copyright (C) 2021 the V8 project authors. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider combining with https://github.com/tc39/proposal-temporal/blob/main/polyfill/test/Instant/prototype/subtract/result-out-of-range.js

test/built-ins/Temporal/Instant/prototype/subtract/throw-type-error-from-RequireInternalSlot.js
@@ -0,0 +1,18 @@
// Copyright (C) 2021 the V8 project authors. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using https://github.com/tc39/proposal-temporal/blob/main/polyfill/test/Instant/prototype/subtract/branding.js

@FrankYFTang
Copy link
Contributor Author

ok, let me just abandon this PR and wait for @ptomato and @Ms2ger to move their test from Temporal repo instead.

@FrankYFTang FrankYFTang closed this Aug 9, 2021
ptomato pushed a commit to ptomato/test262 that referenced this pull request Mar 11, 2022
@FrankYFTang @ptomato
Add tests for Temporal.Instant.p*.subtract
be9faf7 
(Philip, March 2022: I rebased Frank's original PR tc39#3076, did some
reformatting, removed duplicate tests, and combined with some existing
tests.)
@ptomato ptomato mentioned this pull request Mar 11, 2022
Merged
ptomato pushed a commit to ptomato/test262 that referenced this pull request Mar 12, 2022
@FrankYFTang @ptomato
Add tests for Temporal.Instant.p*.subtract
751604b 
(Philip, March 2022: I rebased Frank's original PR tc39#3076, did some
reformatting, removed duplicate tests, and combined with some existing
tests.)
rwaldron pushed a commit that referenced this pull request Mar 14, 2022
@FrankYFTang @rwaldron
Add tests for Temporal.Instant.p*.subtract
11c2559 
(Philip, March 2022: I rebased Frank's original PR #3076, did some
reformatting, removed duplicate tests, and combined with some existing
tests.)
@FrankYFTang FrankYFTang deleted the instSubtract branch July 21, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptomato ptomato ptomato left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrankYFTang @ptomato