[bigint] ToNumeric type coercion tests via "-UnaryExpression" #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 25, 2017 15:26
* Number.prototype.toString() has a lot of implementation-specified behavior, which means we shouldn't test something like (123.456).toString(). * Fix copypaste error * ToBigInt error tests should also test ToPrimitive errors.
…here in the same file
rwaldron
changed the title
rwaldron
changed the title
|
Following up from the review feedback in #1241, this PR needs to take a different approach. I'll open a new PR for this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the BigInt spec changes, unary minus uses ToNumeric instead of just ToNumber. This test uses a unary minus expression to test the type coercion corner cases for ToNumeric.
This PR is based on #1241. Not sure I did all the paperwork properly to indicate and facilitate that.