-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ECMA-402 proposals #77
Conversation
93f0b13
to
f545e8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was kind of thinking that all the 402 stuff should go in a subfolder, ecma-402/
or something - that way reviews can be split up more easily.
I'd thus expect the same lists of finished/inactive/stage0 inside that subdir.
@ljharb do you mean that ECMA-262 proposals should remain in root and ECMA-402 should be in subdirectory? Where should be a link to ECMA-402 proposals in that case? Somewhere after ECMAScript proposals list? IMHO having proposals to both specs on one page is very handy. |
@chicoxyzzy yes; that's what i mean - that they'd be on two separate lists. I'd expect a link to the 402 proposals to appear prominently at the top of the main readme, though. |
097d519
to
922ce86
Compare
922ce86
to
7e24bf4
Compare
PR updated |
ecma420/finished-proposals.md
Outdated
|--------------------------------------------------------------------------|------------------------------------|--------------------|---------------------------| | ||
| [Intl.DateTimeFormat.prototype.formatToParts][] | Zibi Braniecki | [July 2016][Intl.DateTimeFormat.prototype.formatToParts-notes] | 2017 | ||
| [Intl.NumberFormat.prototype.formatToParts][] | Zibi Braniecki | [September 2017][Intl.NumberFormat.prototype.formatToParts-notes] | 2018 | ||
| [Intl.PluralRules][] | Caridy Patiño, Eric Ferraiuolo | [September 2017][Intl.PluralRules] | 2018 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/ecma420/ecma402 :-)
Overall this looks good tho! I'll let both @caridy and @littledan approve before merging, regardless.
420 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks great!
- if you are a TC39 delegate, but not an admin in that organization, please contact @LJHarb | ||
2. @bterlson will transfer your repository to the TC39 organization the next chance he gets. | ||
|
||
Note that as part of the onboarding process your repository name may be normalized. Don't worry, redirects will continue to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't really true; GitHub pages just breaks. However, this is the process anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah true; this (which was copypasted from the main readme) should be clarified to say that repo URLs will redirect and github pages will break.
|
||
1. Transfer your repository to the [@tc39-transfer](http://github.com/tc39-transfer) organization | ||
- if you are a TC39 delegate, but not an admin in that organization, please contact @LJHarb | ||
2. @bterlson will transfer your repository to the TC39 organization the next chance he gets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do this too if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good, I'd want to get @caridy 's look before merging though, as he's the 402 editor.
Overall, I wonder if this would be more clear if it were just on one page (since the number of proposals is relatively small) rather than requiring people to click around. I don't have a strong opinion though.
Thanks! Let's merge this as-is; we can make followup PRs to explore combining the 402 lists into one, and to clarify the transfer process in both 262 and 402. |
According to #76