Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

Normative: rename deref to get #116

Closed
wants to merge 1 commit into from

Conversation

littledan
Copy link
Member

Suggestion from Kenneth Christiansen
w3ctag/design-reviews#321 (comment)

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much better name imo

@erights
Copy link
Contributor

erights commented May 22, 2019

Reject this PR. We started with get and renamed to deref on purpose.

Attn @dtribble

@littledan
Copy link
Member Author

@erights I missed this discussion. What was the rationale?

@syg
Copy link
Collaborator

syg commented May 28, 2019

I don't recall the original discussion, but I also dislike "get". I think it's too general a term for a very specific concept that'll come up often in discussion, both written and spoken. Imagine a hypothetical convo of explaining WeakRef semantics to someone unfamiliar:

Alice: A gotten WeakRef is guaranteed to live for the turn of the event loop.
Bob: Gotten from where?
Alice: I mean a WeakRef that had "get" called on it.

@littledan
Copy link
Member Author

cc @kenchris

@littledan
Copy link
Member Author

OK, given the hesitation here from @erights, @gsathya and @syg, let's conclude that we're not making this name change.

@littledan littledan closed this May 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants