Rename default method #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discussion in #3 yielded the following conclusions as of 2019-11-25: - We only want to support v4 UUIDs initially - Exporting them as uuid() might cause confusion should we ever want to support other algoritihms in the future. - Using "v4" in the name seems to cause more confusion than clarification since the whole "Version" terminology in the RFC is pretty confusing per se. - Using the term "random" to describe v4 UUIDs yielded generally positive feedback and other languages/libraries seem to use it as well. - There's general agreement that we should not support algorithms other than v4 random UUIDs for now.
ctavan
force-pushed
the
rename-default-method
branch
from
0612c02
to
abada13
Compare
Discussion in #3 showed that there is general agreement for only supporting the v4 algorithm. However, there are concerns that, if we design an API that promotes one algorithm as the default, this assumption might not hold in the future. In order to provide a more future-proof API we may therefore only support certain algorithms, but will likely not treat any of the supported algorithms in a speacial way.
bakkot
approved these changes
Nov 25, 2019
rmg
approved these changes
Nov 25, 2019
bcoe
approved these changes
Nov 26, 2019
bcoe
approved these changes
Nov 27, 2019
|
let's leave this open for a bit and give @broofa, @littledan, and a few other folks a chance to chime in. |
broofa
approved these changes
Nov 27, 2019
Co-Authored-By: Robert Kieffer <[email protected]>
Co-Authored-By: Robert Kieffer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion in #3 yielded the following conclusions as of 2019-11-25:
We are still undecided whether we want to propose additional functionality around parsing UUIDs or outputting them in representations other than strings (e.g. bytes).
@rmg feel free to have a look as well!