Skipping transpilation won't discourage minifying #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here and elsewhere, we've seen arguments that this proposal will encourage users to skip minifying their code. (I think the argument is that since users are required to transpile, that will also encourage them to minify.) The FAQ has an entry on this, but I wanted to elaborate on it, by pointing out that no popular transpiler minifies by default. Minification always requires a separate, non-default step.
dfabulich
requested review from
giltayar,
DanielRosenwasser,
robpalme,
orta and
romulocintra
as code owners
|
FYI, the Closure Compiler transpiles modern JavaScript code to older versions of JavaScript (e.g. from ECMASCRIPT_2021 to ECMASCRIPT5) and minifies by default. Aside: for the record, I disagree with the arguments that this proposal will encourage users to skip minifying their code, and I welcome your elaboration in this PR. |
ljharb
reviewed
Aug 11, 2022
Co-authored-by: Jordan Harband <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here and elsewhere, we've seen arguments that this proposal will encourage users to skip minifying their code. (I think the argument is that since users are required to transpile, that will also encourage them to minify.)
The FAQ has an entry on this, but I wanted to elaborate on it, by pointing out that no popular transpiler minifies by default. Minification always requires a separate, non-default step.