Skip to content
This repository has been archived by the owner on Aug 29, 2021. It is now read-only.

Editorial: Alternative wording for deferred DFS sort #181

Closed
wants to merge 1 commit into from

Conversation

guybedford
Copy link
Collaborator

This provides an alternative wording to making AsyncEvaluation an explicitly ordered field, by instead more generally referencing the original DFS ordering.

This ordering is clearly defined for a given module as the first InnerModuleEvaluation call for a given module that causes the evaluation state transition on that module.

I've kept the note that AsyncEvaluation's transition can be seen to be that same ordering, but then no longer treating that as the definition itself but rather just a note for verification / implementation.

@codehag
Copy link
Collaborator

codehag commented May 20, 2021

I don't have any issues, but I found the previous version easier to model conceptually. This has switched from intention to how it works mechanically, which I think is less preferable. I think the intention was more important.

@codehag
Copy link
Collaborator

codehag commented May 25, 2021

I believe we will stick with the current wording.

@codehag codehag closed this May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants