This repository has been archived by the owner on Aug 29, 2021. It is now read-only.
update spec.html to current spec #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, I'll try to look in detail soon. |
Ms2ger
suggested changes
May 26, 2020
|
|
||
| <p>The InnerModuleEvaluation abstract operation is used by Evaluate to perform the actual evaluation process for the Cyclic Module Record _module_, as well as recursively on all other modules in the dependency graph. The _stack_ and _index_ parameters, as well as _module_'s [[DFSIndex]] and [[DFSAncestoreIndex]] fields, are used the same way as in InnerModuleLinking.</p> | ||
| <h1>InnerModuleEvaluation ( _module_, _stack_, _index_ )</h1> | ||
| <p>The abstract operation InnerModuleEvaluation takes arguments _module_ (a Source Text Module Record), _stack_, and _index_. It is used by Evaluate to perform the actual evaluation process for _module_, as well as recursively on all other modules in the dependency graph. The _stack_ and _index_ parameters, as well as _module_'s [[DFSIndex]] and [[DFSAncestorIndex]] fields, are used the same way as in InnerModuleLinking. It performs the following steps when called:</p> |
There was a problem hiding this comment.
Upstream bug, it seems: module need not be a Source Text Module Record.
There was a problem hiding this comment.
Should we do the change there first?
codehag
force-pushed
the
update-spec
branch
3 times, most recently
from
ec38e43 to
19d2a2a
Compare
codehag
commented
May 27, 2020
| </emu-clause> | ||
|
|
||
| <emu-clause id="sec-toplevelmoduleevaluationjob" aoid="TopLevelModuleEvaluationJob"> |
There was a problem hiding this comment.
This section is moved to the bottom, unchanged, from line 1032
Ms2ger
suggested changes
Jun 10, 2020
|
|
||
| <p>The InnerModuleEvaluation abstract operation is used by Evaluate to perform the actual evaluation process for the Cyclic Module Record _module_, as well as recursively on all other modules in the dependency graph. The _stack_ and _index_ parameters, as well as _module_'s [[DFSIndex]] and [[DFSAncestoreIndex]] fields, are used the same way as in InnerModuleLinking.</p> | ||
| <h1>InnerModuleEvaluation ( _module_, _stack_, _index_ )</h1> | ||
| <p>The abstract operation InnerModuleEvaluation takes arguments _module_ (a Source Text Module Record), _stack_, and _index_. It is used by Evaluate to perform the actual evaluation process for _module_, as well as recursively on all other modules in the dependency graph. The _stack_ and _index_ parameters, as well as _module_'s [[DFSIndex]] and [[DFSAncestorIndex]] fields, are used the same way as in InnerModuleLinking. It performs the following steps when called:</p> |
…pdate accordingly
…ht place to move these instructions to
Ms2ger
suggested changes
Jun 10, 2020
|
sorry it took a while to do those @Ms2ger -- do you have further comments? |
codehag
commented
Jul 14, 2020
spec.html
Outdated
| @@ -1022,36 +1022,6 @@ <h1>ExecuteModule ( <ins>[ _capability_ ]</ins> ) Concrete Method</h1> | |||
| </emu-clause> | |||
| </emu-clause> | |||
|
|
|||
| <emu-clause id="sec-toplevelmoduleevaluationjob" aoid="TopLevelModuleEvaluationJob"> | |||
There was a problem hiding this comment.
It might be that this was moved into html but I don't know the full context: https://html.spec.whatwg.org/#fetch-the-descendants-of-and-link-a-module-script
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
This is related to my issue #139 where I was having a hard time seeing what was different between the proposal and the existing spec. There are a couple of changes that have happened in the last year which were not merged into this spec. I tried to get all of them.
The biggest one is that TopLevelEvaluationJob no longer exists (https://tc39.es/proposal-top-level-await/#sec-toplevelmoduleevaluationjob) removed in (https://github.com/tc39/ecma262/pull/1597/files). It is not in this pull request either, because I wasn't sure which part of thee spec this would now touch.
the other significant change is https://tc39.es/proposal-top-level-await/#sec-source-text-module-record-execute-module -- in the original, the change was quite small, but now it is larger. I don't know if this is accurate.
I think we could do with some tooling to make these diffs easier... Looking forward to peoples comments.
You can see the "diff" from the current to the version in this repo here: https://github.com/codehag/proposal-top-level-await/pull/1/files