Fixes #848
Merged
Fixes #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes `npm run lint -- --fix`.
ptomato
requested review from
Ms2ger,
justingrant,
pipobscure,
jasonwilliams,
sffc,
gibson042 and
ryzokuken
Codecov Report
@@ Coverage Diff @@
## main #848 +/- ##
=======================================
Coverage 92.35% 92.35%
=======================================
Files 17 17
Lines 4840 4841 +1
Branches 751 752 +1
=======================================
+ Hits 4470 4471 +1
Misses 363 363
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
justingrant
approved these changes
Aug 25, 2020
Ms2ger
previously requested changes
Aug 26, 2020
Although they were never used in any observable output, the polyfill's ParseISODateTime would generate offset strings like '+undefined:00' when parsing a string with a Z designator. Change the spec accordingly, to always make the result of parsing a time zone string with a Z equivalent to "+00:00[UTC]". Remove some duplicated logic.
GetEpochFromParts returns null if the DateTime fields are outside of the supported Date range. Callers need to check for a null return value.
If we change Absolute to use the offset and not the bracket name, then these tests will start failing.
This was an oversight in the spec.
|
@Ms2ger Can you check this one again? It can't be merged until you mark that the requested changes have been addressed. |
|
Oh, never mind, you can "dismiss review" if the comments have been addressed ... which strikes me as a bit rude though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miscellaneous fixes.