Allow Unicode minus sign (U+2212) in ISO 8601 strings #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
requested review from
Ms2ger,
justingrant,
pipobscure,
jasonwilliams,
sffc,
gibson042 and
ryzokuken
Codecov Report
@@ Coverage Diff @@
## main #826 +/- ##
=======================================
Coverage 92.38% 92.39%
=======================================
Files 17 17
Lines 4834 4839 +5
Branches 749 752 +3
=======================================
+ Hits 4466 4471 +5
Misses 362 362
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Merged
Wherever a sign character is needed (in 6-digit extended years and in time zone offsets), also accept the Unicode minus sign as well as the normal ASCII + and -. Closes: #814
ptomato
force-pushed
the
814-unicode-minus
branch
from
954a89d to
845dd3e
Compare
|
Comments addressed, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wherever a sign character is needed (in 6-digit extended years and in
time zone offsets), also accept the Unicode minus sign as well as the
normal ASCII + and -.
Closes: #814