Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explainer for LocalDateTime #816

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Add explainer for LocalDateTime #816

merged 1 commit into from
Aug 13, 2020

Conversation

ptomato
Copy link
Collaborator

@ptomato ptomato commented Aug 12, 2020

I intend to eventually adapt this into the documentation for
LocalDateTime, but given the draft status of the API this seems more
appropriate.

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #816 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #816   +/-   ##
=======================================
  Coverage   92.26%   92.26%           
=======================================
  Files          17       17           
  Lines        4796     4796           
  Branches      751      751           
=======================================
  Hits         4425     4425           
  Misses        369      369           
  Partials        2        2           
Flag Coverage Δ
#test262 55.91% <ø> (ø)
#tests 87.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abe1f54...8ad09a5. Read the comment docs.

docs/localdatetime-draft.md Outdated Show resolved Hide resolved
docs/localdatetime-draft.md Outdated Show resolved Hide resolved
docs/localdatetime-draft.md Outdated Show resolved Hide resolved
docs/localdatetime-draft.md Outdated Show resolved Hide resolved
@justingrant
Copy link
Collaborator

This is great. I noticed a few missing things:

Copy link
Collaborator

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making my suggested changes!

I intend to eventually adapt this into the documentation for
LocalDateTime, but given the draft status of the API this seems more
appropriate.
@ptomato
Copy link
Collaborator Author

ptomato commented Aug 13, 2020

Added highlighting to Prism in order to fix the docs build.

@ptomato ptomato merged commit 37391be into main Aug 13, 2020
@ptomato ptomato deleted the localdatetime-explainer branch August 13, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants