Fix Time.from when param is another Time
#736
Conversation
- Fixes tc39#735. - Adds tests for `Time.from` when the source is `Time` or `DateTime`. - Also corrects an inaccurate comment.
Codecov Report
@@ Coverage Diff @@
## main #736 +/- ##
=======================================
Coverage 92.33% 92.33%
=======================================
Files 17 17
Lines 4734 4735 +1
Branches 744 744
=======================================
+ Hits 4371 4372 +1
Misses 360 360
Partials 3 3
Continue to review full report at Codecov.
|
| minute = GetSlot(item, MINUTE); | ||
| second = GetSlot(item, SECOND); | ||
| millisecond = GetSlot(item, MILLISECOND); | ||
| microsecond = GetSlot(item, MICROSECOND); | ||
| nanosecond = GetSlot(item, NANOSECOND); | ||
| } else { | ||
| // Intentionally alphabetical | ||
| // Intentionally largest to smallest units |
There was a problem hiding this comment.
For future reference, we can just delete this comment, but no need to block the PR on it. (Calling the property getters on a passed-in object in alphabetical order is mandated by the spec, which is now implemented in ES.ToTemporalTimeRecord. Here, they can be in any old order.
There was a problem hiding this comment.
Calling the property getters on a passed-in object in alphabetical order is mandated by the spec
OK, got it. Out of curiosity, why is alpha order required?
There was a problem hiding this comment.
Alphabetical doesn't really matter, but some order is required to be specified, since the calls are observable by client code if you pass in a Proxy, for example. I'm not sure why alphabetical was chosen originally as the arbitrary order, but I'd guess it's because there's some precedent elsewhere.
Temporal.Time.fromfails when anotherTimeobject is supplied #735.Time.fromwhen the source isTimeorDateTime.