Calendar formatter #660
Closed
Calendar formatter #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since MonthDay.withYear(year) is not guaranteed to be sufficient to convert to a Temporal.Date if the calendar uses eras as well as years. Instead of picking the arbitrary day 1 or year 2004 to convert, use the refISODay or refISOYear, respectively.
ptomato
requested review from
pipobscure,
jasonwilliams,
sffc,
gibson042 and
ryzokuken
Codecov Report
@@ Coverage Diff @@
## main #660 +/- ##
===========================================
- Coverage 95.99% 53.19% -42.80%
===========================================
Files 17 16 -1
Lines 4040 1912 -2128
Branches 663 489 -174
===========================================
- Hits 3878 1017 -2861
- Misses 159 756 +597
- Partials 3 139 +136
Continue to review full report at Codecov.
|
ryzokuken
approved these changes
Jun 10, 2020
polyfill/lib/intl.mjs
Outdated
Comment on lines
102
to
103
| console.log(aa.getEpochMilliseconds(), bb.getEpochMilliseconds()); | ||
| console.log(formatter.resolvedOptions()); |
ptomato
force-pushed
the
calendar-formatter
branch
from
31f3d7b to
1e1416f
Compare
|
Actually, scratch this — both these commits depend on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split this out from #638, for ease of review, because it's able to be merged separately.