Editorial: Remove unnecessary checks for undefined before ToPositiveInteger #2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nteger `ToPositiveInteger(undefined)` calls `ToIntegerThrowOnInfinity(undefined)`, which in turn calls `ToIntegerOrInfinity(undefined)`, which in turn calls `ToNumber(undefined)`. `ToNumber` returns `NaN`, `ToIntegerOrInfinity` then returns `0`, `ToIntegerThrowOnInfinity` returns `0` unchanged, and finally `ToPositiveInteger` will throw a RangeError for `0`. That means it's not necessary to handle `undefined` before calling `ToPositiveInteger`.
Codecov Report
@@ Coverage Diff @@
## main #2332 +/- ##
=======================================
Coverage 91.09% 91.09%
=======================================
Files 19 19
Lines 10579 10579
Branches 1696 1696
=======================================
Hits 9637 9637
Misses 932 932
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToPositiveInteger(undefined)callsToIntegerThrowOnInfinity(undefined), which in turn callsToIntegerOrInfinity(undefined), which in turn callsToNumber(undefined).ToNumberreturnsNaN,ToIntegerOrInfinitythen returns0,ToIntegerThrowOnInfinityreturns0unchanged, and finallyToPositiveIntegerwill throw a RangeError for0. That means it's not necessary to handleundefinedbefore callingToPositiveInteger.Split from #2265.