-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand string parsing/formatting documentation, including a new FAQ #2059
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2059 +/- ##
=======================================
Coverage 93.87% 93.87%
=======================================
Files 19 19
Lines 11011 11011
Branches 1609 1609
=======================================
Hits 10337 10337
Misses 654 654
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
4c5555d
to
96311f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Expands "ISO Extensions" page in the docs into a more comprehensive overview of using strings in Temporal, including a new FAQ. Also renames the URL of that page to be more generic, and updates links to it.
96311f0
to
9d6a168
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All @ptomato comments should be addressed in the latest commit.
Expands "ISO Extensions" page in the docs into a more comprehensive overview of using strings in Temporal, including a new FAQ.
Also renames the URL of that page to be more generic, and updates links to it.
This is a fairly large content update so I expect there to be typos and changes needed.
Fixes #2046.