Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand string parsing/formatting documentation, including a new FAQ #2059

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

justingrant
Copy link
Collaborator

Expands "ISO Extensions" page in the docs into a more comprehensive overview of using strings in Temporal, including a new FAQ.

Also renames the URL of that page to be more generic, and updates links to it.

This is a fairly large content update so I expect there to be typos and changes needed.

Fixes #2046.

@justingrant justingrant requested a review from ptomato February 13, 2022 09:39
@codecov
Copy link

codecov bot commented Feb 13, 2022

Codecov Report

Merging #2059 (9d6a168) into main (3f2b758) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2059   +/-   ##
=======================================
  Coverage   93.87%   93.87%           
=======================================
  Files          19       19           
  Lines       11011    11011           
  Branches     1609     1609           
=======================================
  Hits        10337    10337           
  Misses        654      654           
  Partials       20       20           
Flag Coverage Δ
test262 81.37% <ø> (ø)
tests 87.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f2b758...9d6a168. Read the comment docs.

Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

docs/strings.md Show resolved Hide resolved
docs/strings.md Outdated Show resolved Hide resolved
docs/strings.md Outdated Show resolved Hide resolved
docs/strings.md Show resolved Hide resolved
docs/strings.md Show resolved Hide resolved
Expands "ISO Extensions" page in the docs into a more comprehensive
overview of using strings in Temporal, including a new FAQ.

Also renames the URL of that page to be more generic, and updates links
to it.
Copy link
Collaborator Author

@justingrant justingrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All @ptomato comments should be addressed in the latest commit.

docs/strings.md Show resolved Hide resolved
docs/strings.md Outdated Show resolved Hide resolved
docs/strings.md Show resolved Hide resolved
docs/strings.md Show resolved Hide resolved
@justingrant justingrant merged commit 98f90c8 into tc39:main Feb 16, 2022
@ptomato ptomato added the no-spec-text PR can be ignored by implementors label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-spec-text PR can be ignored by implementors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document string-parsing FAQ in the string-parsing docs page
2 participants