Document PlainDateTime use cases #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1344 +/- ##
=======================================
Coverage 95.08% 95.08%
=======================================
Files 19 19
Lines 9692 9692
Branches 1525 1525
=======================================
Hits 9216 9216
Misses 468 468
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
ryzokuken
approved these changes
Feb 8, 2021
SimenB
reviewed
Feb 8, 2021
| For example, the British Commonwealth observes a [two minute silence](https://en.wikipedia.org/wiki/Two-minute_silence) every November 11th at 11:00AM in local time. | ||
| - When time zone is irrelevant, e.g. a sleep tracking device that only cares about the local time you went to sleep and woke up, regardless of where in the world you are. | ||
| - Parsing local time from ISO 8601 strings like `2020-04-09T16:08-08:00` that have a numeric offset without an IANA time zone like `America/Los_Angeles`. | ||
| These strings can also be parsed by `Temporal.Absolute`, but to parse the local date and time then `Temporal.PlainDateTime.from` is required. |
There was a problem hiding this comment.
Temporal.Absolute should be Temporal.Instant, no?
There was a problem hiding this comment.
@SimenB oops, yes! I missed that, and looks like @justingrant wrote this before Absolute was renamed to Instant. Let me make a quick follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #948