Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date/Time.toZonedDateTime #1129

Merged
merged 2 commits into from
Nov 5, 2020
Merged

Date/Time.toZonedDateTime #1129

merged 2 commits into from
Nov 5, 2020

Conversation

Ms2ger
Copy link
Collaborator

@Ms2ger Ms2ger commented Nov 5, 2020

See #889.

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #1129 into main will decrease coverage by 3.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1129      +/-   ##
==========================================
- Coverage   93.55%   90.07%   -3.48%     
==========================================
  Files          19       17       -2     
  Lines        7961     8305     +344     
  Branches     1264     1207      -57     
==========================================
+ Hits         7448     7481      +33     
- Misses        506      813     +307     
- Partials        7       11       +4     
Flag Coverage Δ
test262 ?
tests 90.07% <ø> (+0.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
polyfill/lib/slots.mjs
polyfill/lib/shim.mjs
polyfill/lib/legacydate.mjs
polyfill/lib/intrinsicclass.mjs
lib/slots.mjs 100.00% <0.00%> (ø)
lib/zoneddatetime.mjs 83.04% <0.00%> (ø)
lib/temporal.mjs 100.00% <0.00%> (ø)
lib/plainmonthday.mjs 84.88% <0.00%> (ø)
lib/ecmascript.mjs 93.92% <0.00%> (ø)
lib/intrinsicclass.mjs 56.81% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab3c02...b700ebd. Read the comment docs.

@Ms2ger
Copy link
Collaborator Author

Ms2ger commented Nov 5, 2020

Docs will need an update too.

Copy link
Collaborator

@justingrant justingrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased these and it was straightforward. 👍

@ptomato ptomato marked this pull request as ready for review November 5, 2020 22:01
@ptomato ptomato merged commit 5ce8675 into main Nov 5, 2020
@ptomato ptomato deleted the date-toZonedDateTime branch November 5, 2020 22:03
@ptomato
Copy link
Collaborator

ptomato commented Nov 5, 2020

Let's keep the docs change for a follow-up.

@justingrant
Copy link
Collaborator

I'm already planning to do the TS types updates corresponding to this and similar PRs, so I can do the docs updates too as part of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants