-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date/Time.toZonedDateTime #1129
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1129 +/- ##
==========================================
- Coverage 93.55% 90.07% -3.48%
==========================================
Files 19 17 -2
Lines 7961 8305 +344
Branches 1264 1207 -57
==========================================
+ Hits 7448 7481 +33
- Misses 506 813 +307
- Partials 7 11 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Docs will need an update too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
f2bb168
to
b700ebd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased these and it was straightforward. 👍
Let's keep the docs change for a follow-up. |
I'm already planning to do the TS types updates corresponding to this and similar PRs, so I can do the docs updates too as part of that. |
See #889.