Fix order of operations in subtract and direction in since
#1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was the first time prettier was run on this file, so many format and whitespace changes. No content changes.
Other specs aren't updated yet, but this change was trivial. Changes for `since` are still TBD here and in other specs.
This commit contains changes to remove Calendar's dateSubtract and timeSubtract methods, as well as the DateSubtract abstract operation. No changes in this checkin actually change any logic, so it should be quicker to review than the other commits in this PR.
This commit updates the ISO calendar's `dateAdd` to work with negative durations, and removes dateSubtract & timeSubtract methods from the implementation.
Updates `ES.DifferenceDate` to perform reversible, largest-units-first date arithmetic. I didn't spend a lot of time optimizing, so the algorithm can surely be improved later.
Now that order-of-operations works, these tests now pass.
This commit changes Date, DateTIme, YearMonth, and Time to: * Revise `subtract` to use largest-units-first order of operations * Fixes `since` to use largest-units-first order of operations and to always use `this` as the starting point for both arithmetic and rounding. * A few test changes to adjust to new results and to test the new OOO
This was referenced Nov 5, 2020
Codecov Report
@@ Coverage Diff @@
## main #1123 +/- ##
==========================================
- Coverage 93.55% 90.17% -3.39%
==========================================
Files 19 17 -2
Lines 7961 8261 +300
Branches 1264 1202 -62
==========================================
+ Hits 7448 7449 +1
- Misses 506 801 +295
- Partials 7 11 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Ms2ger
approved these changes
Nov 5, 2020
|
Test262 is still broken in CI, but I just pushed a 2-character commit that fixes Test262 when run locally. Now all tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MERGE THIS PR BEFORE #1116. @ptomato will update that PR so its tests will work with the changes in this PR.
#1121 may also break this PR... not sure though. Ideally this PR could be merged first.This PR fixes #993 by:
subtract()methods to use largest-units-first order of operationssince()methods to use largest-units-first order of operations and to always usethisas the starting point for both arithmetic and rounding.dateSubtract&timeSubtractfrom Calendar.*Subtractabstract operationsI split this up into multiple commits to make it easier to review. Some of the commits are trivial changes (e.g. deleting stuff from specs and docs, or prettier changes) while others have logic that needs review.
If you're in a hurry, the most important commits to review are these:
DifferenceDateabstract operationsubtractandsincein various Temporal typesFollow-ups needed:
sinceand tests for DateTime and YearMonth.ES.DifferenceDate,*.subtract, or*.since