Accept strings in with() methods #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Date.with(), DateTime.with(), and Time.with() (and in the future in ZonedDateTime.with(),) we now accept strings as well as property bags. The strings are parsed as if with ZonedDateTime.from(), Date.from(), DateTime.from(), and Time.from() in order, with the stipulation that Date.from() is skipped if a time part is present in the string. (Otherwise you would never get a DateTime since Date.from(YYYY-MM-DDTHH:MM:SS) gives you YYYY-MM-DD.) The useful reasons to do this are DateTime.with(dateString), DateTime.with(timeString), ZonedDateTime.with(dateString), ZonedDateTime.with(timeString), and ZonedDateTime.with(dateTimeString). However, for the sake of consistency, we allow it as much as possible in other cases. Cases were it is not allowed are, YearMonth.with() and MonthDay.with(), which cannot accept calendars in their property bags, so passing other Temporal objects there is not allowed in the first place; and YYYY-MM and MM-DD strings, which are ambiguous with HHMM-ZZ and HH-ZZ. Closes: #934
ptomato
requested review from
Ms2ger,
justingrant,
pipobscure,
jasonwilliams,
sffc,
gibson042,
mattjohnsonpint and
ryzokuken
Codecov Report
@@ Coverage Diff @@
## main #1027 +/- ##
==========================================
- Coverage 94.23% 94.22% -0.02%
==========================================
Files 18 18
Lines 6284 6321 +37
Branches 932 945 +13
==========================================
+ Hits 5922 5956 +34
- Misses 355 358 +3
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Ms2ger
approved these changes
Oct 21, 2020
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #934