Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporal.Duration.prototype.total: Condition to convert zonedRelativeTo to plainRelativeTo incorrect #2681

Closed
anba opened this issue Sep 25, 2023 · 1 comment
Closed

Temporal.Duration.prototype.total: Condition to convert zonedRelativeTo to plainRelativeTo incorrect #2681

anba opened this issue Sep 25, 2023 · 1 comment

Comments

@anba
Copy link
Contributor

anba commented Sep 25, 2023

Step 11:

If zonedRelativeTo is not undefined; and unit is any of "year", "month", "week"; and any of duration.[[Years]], duration.[[Months]], duration.[[Weeks]] ≠ 0; then

The both conditions should be connected through "or" instead of "and", that means

If zonedRelativeTo is not undefined; and unit is any of "year", "month", "week"; or any of duration.[[Years]], duration.[[Months]], duration.[[Weeks]] ≠ 0; then
@ptomato
Copy link
Collaborator

ptomato commented Sep 25, 2023

That's correct. However, this is fixed anyway in #2671 ("Normative: Precalculate PlainDateTime from ZonedDateTime in more places") so I'll leave this alone for now.

ptomato added a commit that referenced this issue Sep 26, 2023
@ptomato
Normative: Precalculate PlainDateTime from ZonedDateTime in more places
51b4114 
There are a few more places where we can avoid doing an additional lookup
and call of getOffsetNanosecondsFor on the same ZonedDateTime, to convert
it into a PlainDateTime.

This affects

- Temporal.Duration.prototype.add (with relativeTo ZonedDateTime)
- Temporal.Duration.prototype.subtract (ditto)
- Temporal.Duration.prototype.round (ditto)
- Temporal.Duration.prototype.total (ditto)
- Temporal.ZonedDateTime.prototype.since
- Temporal.ZonedDateTime.prototype.until

(also fixes "and" vs "or" prose mistakes)
Closes: #2680
Closes: #2681
ptomato added a commit that referenced this issue Sep 26, 2023
@ptomato
Normative: Precalculate PlainDateTime from ZonedDateTime in more places
03ebf1a 
There are a few more places where we can avoid doing an additional lookup
and call of getOffsetNanosecondsFor on the same ZonedDateTime, to convert
it into a PlainDateTime.

This affects

- Temporal.Duration.prototype.add (with relativeTo ZonedDateTime)
- Temporal.Duration.prototype.subtract (ditto)
- Temporal.Duration.prototype.round (ditto)
- Temporal.Duration.prototype.total (ditto)
- Temporal.ZonedDateTime.prototype.since
- Temporal.ZonedDateTime.prototype.until

(also fixes "and" vs "or" prose mistakes)
Closes: #2680
Closes: #2681
ptomato added a commit that referenced this issue Sep 27, 2023
@ptomato
Normative: Precalculate PlainDateTime from ZonedDateTime in more places
6eeee90 
There are a few more places where we can avoid doing an additional lookup
and call of getOffsetNanosecondsFor on the same ZonedDateTime, to convert
it into a PlainDateTime.

This affects

- Temporal.Duration.prototype.add (with relativeTo ZonedDateTime)
- Temporal.Duration.prototype.subtract (ditto)
- Temporal.Duration.prototype.round (ditto)
- Temporal.Duration.prototype.total (ditto)
- Temporal.ZonedDateTime.prototype.since
- Temporal.ZonedDateTime.prototype.until

(also fixes "and" vs "or" prose mistakes)
Closes: #2680
Closes: #2681
ptomato added a commit that referenced this issue Oct 4, 2023
@ptomato
Normative: Precalculate PlainDateTime from ZonedDateTime in more places
99c5740 
There are a few more places where we can avoid doing an additional lookup
and call of getOffsetNanosecondsFor on the same ZonedDateTime, to convert
it into a PlainDateTime.

This affects

- Temporal.Duration.prototype.add (with relativeTo ZonedDateTime)
- Temporal.Duration.prototype.subtract (ditto)
- Temporal.Duration.prototype.round (ditto)
- Temporal.Duration.prototype.total (ditto)
- Temporal.ZonedDateTime.prototype.since
- Temporal.ZonedDateTime.prototype.until

(also fixes "and" vs "or" prose mistakes)
Closes: #2680
Closes: #2681
@ptomato ptomato closed this as completed in 6eec81d Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ptomato @anba