WIP: Optimizations

https://gist.github.com/arshaw/36d3152c21482bcb78ea2c69591b20e0 Closes: #2792 Closes: #2817
tc39 · May 7, 2024 · 6da3db8 · 6da3db8
1 parent b4b21b3
commit 6da3db8
Show file tree

Hide file tree

Showing 3 changed files with 654 additions and 634 deletions.
diff --git a/polyfill/lib/duration.mjs b/polyfill/lib/duration.mjs
@@ -27,6 +27,7 @@ import {
 import { TimeDuration } from './timeduration.mjs';
 
 const MathAbs = Math.abs;
+const NumberIsNaN = Number.isNaN;
 const ObjectCreate = Object.create;
 
 export class Duration {
@@ -345,9 +346,7 @@ export class Duration {
         ES.DifferenceZonedDateTimeWithRounding(
           relativeEpochNs,
           targetEpochNs,
-          plainRelativeTo,
           calendarRec,
-          zonedRelativeTo,
           timeZoneRec,
           precalculatedPlainDateTime,
           ObjectCreate(null),
@@ -399,7 +398,7 @@ export class Duration {
       if (ES.IsCalendarUnit(smallestUnit)) {
         throw new RangeError(`a starting point is required for ${smallestUnit}s rounding`);
       }
-      ({ days, norm } = ES.RoundDuration(0, 0, 0, days, norm, roundingIncrement, smallestUnit, roundingMode));
+      ({ days, norm } = ES.RoundDuration(days, norm, roundingIncrement, smallestUnit, roundingMode));
       ({ days, hours, minutes, seconds, milliseconds, microseconds, nanoseconds } = ES.BalanceTimeDuration(
         norm.add24HourDays(days),
         largestUnit
@@ -468,9 +467,7 @@ export class Duration {
       const { total } = ES.DifferenceZonedDateTimeWithRounding(
         relativeEpochNs,
         targetEpochNs,
-        plainRelativeTo,
         calendarRec,
-        zonedRelativeTo,
         timeZoneRec,
         precalculatedPlainDateTime,
         ObjectCreate(null),
@@ -479,6 +476,7 @@ export class Duration {
         unit,
         'trunc'
       );
+      if (NumberIsNaN(total)) throw new Error('assertion failed: total hit unexpected code path');
       return total;
     }
 
@@ -513,6 +511,7 @@ export class Duration {
         unit,
         'trunc'
       );
+      if (NumberIsNaN(total)) throw new Error('assertion failed: total hit unexpected code path');
       return total;
     }
 
@@ -524,7 +523,7 @@ export class Duration {
       throw new RangeError(`a starting point is required for ${unit}s total`);
     }
     norm = norm.add24HourDays(days);
-    const { total } = ES.RoundDuration(0, 0, 0, 0, norm, 1, unit, 'trunc');
+    const { total } = ES.RoundDuration(0, norm, 1, unit, 'trunc');
     return total;
   }
   toString(options = undefined) {
@@ -563,7 +562,7 @@ export class Duration {
         microseconds,
         nanoseconds
       );
-      ({ norm } = ES.RoundDuration(0, 0, 0, 0, norm, increment, unit, roundingMode));
+      ({ norm } = ES.RoundDuration(0, norm, increment, unit, roundingMode));
       let deltaDays;
       ({
         days: deltaDays,