This repository has been archived by the owner on Jul 8, 2024. It is now read-only.
Normative: bugfix: do not count ~empty~ in set sizes #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <emu-clause id="sec-setdatasize" type="abstract operation"> | ||
| <h1> | ||
| SetDataSize ( | ||
| _setData_: a List of either ~empty~ or ECMAScript language values, |
There was a problem hiding this comment.
"a List" is sufficient here, but this is also fine.
michaelficarra
approved these changes
Dec 21, 2023
ljharb
added a commit
to es-shims/Set.prototype.intersection
that referenced
this pull request
Feb 6, 2024
ljharb
added a commit
to es-shims/Set.prototype.difference
that referenced
this pull request
Feb 6, 2024
ljharb
added a commit
to es-shims/Set.prototype.isSubsetOf
that referenced
this pull request
Feb 6, 2024
ljharb
added a commit
to es-shims/Set.prototype.isDisjointFrom
that referenced
this pull request
Feb 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various algorithms normatively depend on "the number of elements in
_O_.[[SetData]]". But the[[SetData]]list is completely fictional: it contains~empty~tombstones for deleted elements. We need to skip those when actually using the size in an observable way, but not when using it as a bound for a loop which is indexing[[SetData]].Hopefully no implementations actually implemented the wrong thing, though it's hard to see how they could have.