This repository has been archived by the owner on Jul 8, 2024. It is now read-only.
Bugfix: fix a missed ~empty~ check in isSubsetOf #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's some JS code that would trigger this bug? |
let x = new Set('a', 'b');
let evil = {
size: 3,
has() {
x.delete('b');
x.add('c');
return true;
},
*keys(){}
};
x.isSubsetOf(evil);That ends up calling |
|
gotcha, thanks, LGTM |
ljharb
added a commit
to es-shims/Set.prototype.isSubsetOf
that referenced
this pull request
Nov 25, 2023
|
cc @rmahdav to see if V8 has this bug as well. |
ljharb
added a commit
to es-shims/Set.prototype.isSubsetOf
that referenced
this pull request
Dec 17, 2023
ljharb
added a commit
to es-shims/Set.prototype.isSubsetOf
that referenced
this pull request
Dec 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.