Normative optional, legacy -> Deprecated #133

nicolo-ribaudo · 2023-03-22T23:30:37Z

PR preview: https://nicolo-ribaudo.github.io/proposal-import-assertions

As per the March 2023 TC39 meeting, this pull request changes the assert compatibility fallback from "Normative optional, legacy" to "Deprecated", with this description:

A conforming implementation of ECMAScript should not implement Deprecated subclauses, unless necessary for compatibility with existing applications that already run in such implementation before the deprecation of the given language feature. All of the language features and behaviours specified within Deprecated subclauses have one or more undesirable characteristics. However, their usage in existing applications currently prevents their removal from this specification. These features are not considered part of the core ECMAScript language. Programmers should not use or assume the existence of these features and behaviours when writing new ECMAScript code.

(old description I first used)

A conforming implementation of ECMAScript should not implement Deprecated subclauses. All of the language features and behaviours specified within Deprecated subclauses have one or more undesirable characteristics. However, their usage in existing applications currently prevents their removal from this specification. These features are not considered part of the core ECMAScript language. Programmers should not use or assume the existence of these features and behaviours when writing new ECMAScript code.

For comparison, the "Legacy" description is

A conforming implementation of ECMAScript must implement Legacy subclauses, unless they are also marked as Normative Optional. All of the language features and behaviours specified within Legacy subclauses have one or more undesirable characteristics. However, their continued usage in existing applications prevents their removal from this specification. These features are not considered part of the core ECMAScript language. Programmers should not use or assume the existence of these features and behaviours when writing new ECMAScript code.

Additionally, I added two notes mentioning that removal of assert is being investigated.

cc @ljharb @msaboff

spec.emu

ljharb

i like it!

ljharb · 2023-03-23T17:57:55Z

cc @tc39/ecma262-editors and @syg in particular

spec.emu

michaelficarra · 2023-03-30T19:35:45Z

spec.emu

@@ -121,7 +124,7 @@
              1. Return _promiseCapability_.[[Promise]].
            1. Let _assertionsObj_ be Completion(Get(_options_, *"with"*)).
            1. IfAbruptRejectPromise(_assertionsObj_, _promiseCapability_).
-            1. [normative-optional-legacy=""] If _assertionsObj_ is *undefined*, then
+            1. [deprecated=""] If _assertionsObj_ is *undefined*, then


This isn't a "deprecated subclause". We should probably just have a NOTE step here that gets replaced in a deprecated subclause, much like what we do in Annex B. Search for "replaces-step" for examples to copy.

I was following the path introduced by tc39/ecma262#2952, which inlines Annex B changes to the algorithms rather than replacing NOTE steps out-of-band.

I could update the description of "deprecated" to be "deprecated subclause, step, or production", or I could update this step to be

1. If the host supports the deprecated assert keyword for import attributes and if _assertionsObj_ is *undefined*, then

with "assert keyword for import attributes" linking to an actual deprecated emu-clause that explains what it is.

What do you think about these two options? I would also be happy to join an editors call if needed.

(I pushed a commit to separate the grammar into its own clause, since that ecma262 PR doesn't inline the grammar changes)

Wdyt about this?

@nicolo-ribaudo We'll discuss it during this week's editor call. Feel free to join.

spec.emu

michaelficarra

Wording for dfn of deprecated LGTM, but we need to work on the mechanics of actually applying it, as I've described in my comments.

ljharb · 2023-04-04T17:43:34Z

It'd be great to land this so i can review a spec that includes it :-)

michaelficarra · 2023-04-04T17:46:32Z

@ljharb We're gonna talk about it in editor call tomorrow.

nicolo-ribaudo · 2023-04-06T07:52:35Z

@tc39/ecma262-editors I pushed e1a16a2 based on yesterday's discussion.

Preview of this PR: https://nicolo-ribaudo.github.io/proposal-import-assertions

spec.emu

michaelficarra · 2023-04-06T15:50:44Z

spec.emu

+          <li>It is a Syntax Error if AllImportAttributesSupported(WithClauseToAttributes of |AssertClause|) is *false*.</li>
+        </ul>
+
+        <p>The static semantics of WithClauseToAttributes in <emu-xref href="#sec-with-clause-to-attributes"></emu-xref> are augmented with the following:</p>


I don't think it's unclear that we're inserting these (as opposed to replacing the existing ones), but I think I'd prefer to be more explicit with wording like

Suggested change

<p>The static semantics of WithClauseToAttributes in <emu-xref href="#sec-with-clause-to-attributes"></emu-xref> are augmented with the following:</p>

<p>The static semantics of WithClauseToAttributes in <emu-xref href="#sec-with-clause-to-attributes"></emu-xref> are augmented to include the following:</p>

Also, since we are disallowing these AssertClause nodes from being parsed in the first place using early errors, we don't technically need these definitions to be conditional. We could just put them in WithClauseToAttributes. @tc39/ecma262-editors thoughts?

I think it's nice to keep the deprecated feature as much self contained as possible, rather than scattered across different parts of the spec. If a spec reader doesn't care about it, it's much easier to skip when reading.

spec.emu

bakkot · 2023-04-07T01:51:52Z

Just published ecmarkup 16.2.0, which supports 1. [normative-optional, deprecated] Stuff step labels.

Co-authored-by: Jordan Harband <[email protected]> Co-authored-by: Michael Ficarra <[email protected]>

nicolo-ribaudo · 2023-04-13T11:03:37Z

Thanks, updated!

nicolo-ribaudo · 2023-04-20T14:07:54Z

@tc39/ecma262-editors I plan to merge this PR during the weekend, if there aren't other problems with the changes it introduces. I'd like to get the published spec text (https://tc39.es/proposal-import-attributes/) to its final form to facilitate reviews (#137).

ljharb reviewed Mar 23, 2023

View reviewed changes

spec.emu Outdated Show resolved Hide resolved

nicolo-ribaudo force-pushed the deprecated branch from 114955c to 28e5f6d Compare March 23, 2023 17:51

ljharb approved these changes Mar 23, 2023

View reviewed changes

nicolo-ribaudo force-pushed the deprecated branch from 28e5f6d to df6ae55 Compare March 23, 2023 19:03

nicolo-ribaudo mentioned this pull request Mar 23, 2023

Update references from "import assertions" to "import attributes" whatwg/html#9069

Merged

littledan approved these changes Mar 27, 2023

View reviewed changes

xtuc approved these changes Mar 28, 2023

View reviewed changes

michaelficarra reviewed Mar 30, 2023

View reviewed changes

spec.emu Outdated Show resolved Hide resolved

michaelficarra reviewed Mar 30, 2023

View reviewed changes

spec.emu Outdated Show resolved Hide resolved

michaelficarra suggested changes Mar 30, 2023

View reviewed changes

nicolo-ribaudo mentioned this pull request Mar 31, 2023

Stage 3 reviews #137

Closed

3 tasks

nicolo-ribaudo force-pushed the deprecated branch from 757f896 to 30ab06f Compare March 31, 2023 18:22

bakkot mentioned this pull request Mar 31, 2023

Fix most linting errors #138

Merged

nicolo-ribaudo force-pushed the deprecated branch 2 times, most recently from 51ea854 to d15915f Compare March 31, 2023 21:02

nicolo-ribaudo added this to the stage 3 milestone Apr 3, 2023

nicolo-ribaudo mentioned this pull request Apr 5, 2023

Import Attributes (Stage 3) microsoft/TypeScript#53656

Closed

5 tasks

nicolo-ribaudo force-pushed the deprecated branch 2 times, most recently from 2f59bdd to e1a16a2 Compare April 6, 2023 07:51

michaelficarra reviewed Apr 6, 2023

View reviewed changes

spec.emu Outdated Show resolved Hide resolved

michaelficarra reviewed Apr 6, 2023

View reviewed changes

spec.emu Outdated Show resolved Hide resolved

michaelficarra reviewed Apr 6, 2023

View reviewed changes

ljharb reviewed Apr 6, 2023

View reviewed changes

spec.emu Outdated Show resolved Hide resolved

This was referenced Apr 6, 2023

allow step attributes to be valueless tc39/ecmarkdown#99

Merged

support marking individual steps as legacy/optional/deprecated tc39/ecmarkup#523

Merged

nicolo-ribaudo and others added 9 commits April 13, 2023 12:57

Normative optional, legacy -> Deprecated

a594ae8

Refine wording to more explicitly describe intention

0a551f9

Update intro

fa2b109

Move deprecated syntax to its own clause

862043c

Fix linting errors

3ad4b60

Update wording of deprecated step

c9cdfbf

Feedback from editors call

3c4ff9a

Apply suggestions from code review

3019a0f

Co-authored-by: Jordan Harband <[email protected]> Co-authored-by: Michael Ficarra <[email protected]>

Add back conditional wording

be30172

nicolo-ribaudo force-pushed the deprecated branch from 0410d0a to be30172 Compare April 13, 2023 11:01

Update ecmarkup

94172e2

nicolo-ribaudo force-pushed the deprecated branch from d922219 to 94172e2 Compare April 13, 2023 11:03

michaelficarra approved these changes Apr 20, 2023

View reviewed changes

nicolo-ribaudo merged commit 99ee2c3 into tc39:master Apr 21, 2023

nicolo-ribaudo deleted the deprecated branch April 21, 2023 12:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Normative optional, legacy -> Deprecated #133

Normative optional, legacy -> Deprecated #133

nicolo-ribaudo commented Mar 22, 2023 •

edited

Loading

ljharb left a comment

ljharb commented Mar 23, 2023

michaelficarra Mar 30, 2023

nicolo-ribaudo Mar 31, 2023 •

edited

Loading

nicolo-ribaudo Mar 31, 2023

michaelficarra Apr 3, 2023

michaelficarra left a comment

ljharb commented Apr 4, 2023

michaelficarra commented Apr 4, 2023

nicolo-ribaudo commented Apr 6, 2023 •

edited

Loading

michaelficarra Apr 6, 2023

nicolo-ribaudo Apr 13, 2023 •

edited

Loading

bakkot commented Apr 7, 2023

nicolo-ribaudo commented Apr 13, 2023

nicolo-ribaudo commented Apr 20, 2023

	<p>The static semantics of WithClauseToAttributes in <emu-xref href="#sec-with-clause-to-attributes"></emu-xref> are augmented with the following:</p>
	<p>The static semantics of WithClauseToAttributes in <emu-xref href="#sec-with-clause-to-attributes"></emu-xref> are augmented to include the following:</p>

Normative optional, legacy -> Deprecated #133

Normative optional, legacy -> Deprecated #133

Conversation

nicolo-ribaudo commented Mar 22, 2023 • edited Loading

ljharb left a comment

Choose a reason for hiding this comment

ljharb commented Mar 23, 2023

michaelficarra Mar 30, 2023

Choose a reason for hiding this comment

nicolo-ribaudo Mar 31, 2023 • edited Loading

Choose a reason for hiding this comment

nicolo-ribaudo Mar 31, 2023

Choose a reason for hiding this comment

michaelficarra Apr 3, 2023

Choose a reason for hiding this comment

michaelficarra left a comment

Choose a reason for hiding this comment

ljharb commented Apr 4, 2023

michaelficarra commented Apr 4, 2023

nicolo-ribaudo commented Apr 6, 2023 • edited Loading

michaelficarra Apr 6, 2023

Choose a reason for hiding this comment

nicolo-ribaudo Apr 13, 2023 • edited Loading

Choose a reason for hiding this comment

bakkot commented Apr 7, 2023

nicolo-ribaudo commented Apr 13, 2023

nicolo-ribaudo commented Apr 20, 2023

nicolo-ribaudo commented Mar 22, 2023 •

edited

Loading

nicolo-ribaudo Mar 31, 2023 •

edited

Loading

nicolo-ribaudo commented Apr 6, 2023 •

edited

Loading

nicolo-ribaudo Apr 13, 2023 •

edited

Loading