This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
spec: update second parameter of error constructor with options bag #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Feb 26, 2021
bakkot
reviewed
Feb 26, 2021
ljharb
suggested changes
Mar 1, 2021
ljharb
approved these changes
Mar 1, 2021
spec.emu
Outdated
| 1. <ins>If Type(_options_) is Object and ? HasProperty(_options_, `"cause"`) is *true*, then</ins> | ||
| 1. <ins>Let _cause_ be ? Get(_options_, `"cause"`)</ins> | ||
| 1. <ins>Perform ! CreateErrorObjectProperty(_O_, `"cause"`, _cause_).</ins> | ||
| 1. <ins>Return *undefined*.</ins> |
There was a problem hiding this comment.
It's not required. I was assuming all abstract operations returning with values. If there are no such assumptions in ecma262, I'll remove this line.
bakkot
reviewed
Mar 2, 2021
bakkot
reviewed
Mar 2, 2021
bakkot
approved these changes
Mar 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the second parameter of the error constructor with an options bag. This helps to keep consistency between the DOMException signature and the Error constructor signature, i.e. DOMException may accept an options bag too as the second parameter and populate the cause property.