Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fields and slots should be eligible for ecmarkup interactive highlighting #95

Closed
gibson042 opened this issue Jan 24, 2023 · 0 comments · Fixed by #96
Closed

Fields and slots should be eligible for ecmarkup interactive highlighting #95

gibson042 opened this issue Jan 24, 2023 · 0 comments · Fixed by #96

Comments

@gibson042
Copy link
Contributor

As noted in tc39/proposal-temporal#2290 (review) :

The sticky highlighting becomes less useful [for Record fields than for aliases]. When auditing the uses of BalanceDuration, for example, I found it a lifesaver to be able to highlight years, months, weeks, days, etc. in different colors. If they become durationFieldsRecord.[[Years]] etc., that's no longer possible.

I think fields and slots should participate in interactive highlighting, or at least be eligible, which requires them to have distinct parse nodes here.

gibson042 added a commit to gibson042/ecmarkdown that referenced this issue Jan 24, 2023
bakkot pushed a commit to gibson042/ecmarkdown that referenced this issue Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant