Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix publish-biblio.sh to match actual build #866

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Fix publish-biblio.sh to match actual build #866

merged 2 commits into from
Feb 29, 2024

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Feb 28, 2024

Oops.

@bakkot bakkot mentioned this pull request Feb 28, 2024
Merged
@ryzokuken
Copy link
Member

ryzokuken commented Feb 28, 2024 •
edited
Loading

Damn, you beat me to it! Does loading the 262 biblio make a difference by any chance?

@bakkot
Copy link
Contributor Author

bakkot commented Feb 28, 2024 •
edited
Loading

Yes, though only a tiny bit - the "user code" annotation needs the biblio to flow from AOs in 262 to AOs in 402 (e.g. StringListFromIterable).

402 doesn't enable rendering of that annotation, but it still seems potentially useful to have in the biblio.

@ryzokuken ryzokuken merged commit 52cbba8 into main Feb 29, 2024
3 checks passed
@ryzokuken ryzokuken deleted the bakkot-patch-1 branch February 29, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@ryzokuken ryzokuken ryzokuken approved these changes

@ctcpip ctcpip ctcpip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bakkot @ryzokuken @ljharb @ctcpip