Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Refactor to replace camelCase slot and field names with PascalCase equivalents #769

Closed
wants to merge 40 commits into from
Closed

Editorial: Refactor to replace camelCase slot and field names with PascalCase equivalents #769

wants to merge 40 commits into from

Commits on Mar 14, 2023

  1. changed [[localeMatcher]] to [[LocaleMatcher]] in all relevant places

    @ben-allen
    ben-allen committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    13656ee View commit details
    Browse the repository at this point in the history

  2. changed [[localeMatcher]] to [[LocaleMatcher]] in all relevant places

    @ben-allen
    ben-allen committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    6cafaa8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/ben-allen/ecma402

    @ben-allen
    ben-allen committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    cc4f530 View commit details
    Browse the repository at this point in the history

  4. remove extraneous TODO

    @ben-allen
    ben-allen committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    2036748 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Update notes again to clarify discussion

    @justingrant @ben-allen
    justingrant authored and ben-allen committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    f7e02f2 View commit details
    Browse the repository at this point in the history

  2. Editorial: Add missing internal slots to internalSlotsList (tc39#763) 

    Fixes tc39#762
    @FrankYFTang @ben-allen
    FrankYFTang authored and ben-allen committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    e1e8e19 View commit details
    Browse the repository at this point in the history

  3. Remove ! from calls to AOs that can't throw 

    This commit removes the `!` from two AO calls that return regular values
not abrupt completions.

notes for locale

complete notes for [[locale]]
    @justingrant @ben-allen
    justingrant authored and ben-allen committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    4b9719b View commit details
    Browse the repository at this point in the history

  4. updated all [[locale]] to [[Locale]]

    @ben-allen
    ben-allen committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    7a23ab7 View commit details
    Browse the repository at this point in the history

  5. corrected [[hourCycle]] in datetimeformat.html to [[HourCycle]]. n.b.… 

    …: this was a spec bug! it had been changed to HourCycle in the list of internal slots, but InitializeDateTimeFormat was still using [[hourCycle]]
    @ben-allen
    ben-allen committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    cfd469e View commit details
    Browse the repository at this point in the history

  6. Merge branch 'tc39:master' into capitalization

    @ben-allen
    ben-allen authored Mar 28, 2023
    Configuration menu
    Copy the full SHA
    126e2e0 View commit details
    Browse the repository at this point in the history

  7. [[dataLocale]] on Records returned from ResolveLocale changed to [[Da… 

    …taLocale]]
    @ben-allen
    ben-allen committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    8cddcc4 View commit details
    Browse the repository at this point in the history

  8. [[dataLocale]] on Records returned from ResolveLocale changed to [[Da… 

    …taLocale]]
    @ben-allen
    ben-allen committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    dbb599a View commit details
    Browse the repository at this point in the history

  9. Merge branch 'capitalization' of https://github.com/ben-allen/ecma402 … 

    …into capitalization
    @ben-allen
    ben-allen committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    bba5660 View commit details
    Browse the repository at this point in the history

  10. fixed [[Style]] and [[Sensitivity]]

    @ben-allen
    ben-allen committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    a6c9ff1 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. updated [[format]] to [[Format]] on [[LocaleData]].[[<locale>]]

    @ben-allen
    ben-allen committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    735a1f3 View commit details
    Browse the repository at this point in the history

  2. [[extension]] to [[Extension]]

    @ben-allen
    ben-allen committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    bc24468 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. first attempt at removing the dynamic access from listformat

    @ben-allen
    ben-allen committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    96f9a3e View commit details
    Browse the repository at this point in the history

  2. Replaced dynamic accesses in ListFormat with if/else if

    @ben-allen
    ben-allen committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    0164a0f View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. last commit before refactoring NumberFormat

    @ben-allen
    ben-allen committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    2c6a892 View commit details
    Browse the repository at this point in the history

  2. capitalized several fields from numberformat.html ([[Pattern]], [[Pos… 

    …itivePattern]], [[ZeroPattern]], [[NegativePattern]], [[Unit]], [[Currency]], [[Decimal]], [[UnitDisplay]], [[Code]], [[Symbol]], [[Percent]], [[Narrow]], [[Short]], [[Long]]
    @ben-allen
    ben-allen committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    2a7d3cb View commit details
    Browse the repository at this point in the history

  3. Revert "capitalized several fields from numberformat.html ([[Pattern]… 

    …], [[PositivePattern]], [[ZeroPattern]], [[NegativePattern]], [[Unit]], [[Currency]], [[Decimal]], [[UnitDisplay]], [[Code]], [[Symbol]], [[Percent]], [[Narrow]], [[Short]], [[Long]]"

This reverts commit 2a7d3cb.
    @ben-allen
    ben-allen committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    dad7da8 View commit details
    Browse the repository at this point in the history

  4. [[patterns]] to [[Patterns]]

    @ben-allen
    ben-allen committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    900a1d6 View commit details
    Browse the repository at this point in the history

  5. updated [[Decimal]], [[Percent]], [[Currency]], [[Unit]]

    @ben-allen
    ben-allen committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    2f5dc62 View commit details
    Browse the repository at this point in the history

  6. missed some of the conversions from *percent*, etc. to [[Percent]] fr… 

    …om previous commit
    @ben-allen
    ben-allen committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    e5aa467 View commit details
    Browse the repository at this point in the history

  7. updated fields related to currencyDisplay and currencySign

    @ben-allen
    ben-allen committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    5824ffb View commit details
    Browse the repository at this point in the history

  8. [[ZeroPattern]], [[NegativePattern]], [[PositivePattern]]

    @ben-allen
    ben-allen committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    e669234 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2023

  1. fields related to notationSubPatterns

    @ben-allen
    ben-allen committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    09dfd7d View commit details
    Browse the repository at this point in the history

  2. finished numberformat refactor

    @ben-allen
    ben-allen committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    c10277f View commit details
    Browse the repository at this point in the history

  3. started on DisplayNames -- refactored [[types]]

    @ben-allen
    ben-allen committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    4b83671 View commit details
    Browse the repository at this point in the history

  4. fixed typo in numberformat.html

    @ben-allen
    ben-allen committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    31ccf68 View commit details
    Browse the repository at this point in the history

  5. fixed field names for Records contained within [[Types]]

    @ben-allen
    ben-allen committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    1c71461 View commit details
    Browse the repository at this point in the history

  6. Refactored all of displaynames.html

    @ben-allen
    ben-allen committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    78e4c9c View commit details
    Browse the repository at this point in the history

  7. removed dynamic access [[<unitDisplay>]] / replaced with if-else

    @ben-allen
    ben-allen committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    64e610e View commit details
    Browse the repository at this point in the history

  8. finished displaynames.html

    @ben-allen
    ben-allen committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    cf34e4e View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2023

  1. finished refactoring relativetimeformat.html

    @ben-allen
    ben-allen committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    d10ce42 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. I believe this is technically complete. There are now no lower-case f… 

    …ield names in ECMA402 other than 1) the two-letter ones [[nu]] and so forth, and 2) ones that are never directly named in the spec in any way (i.e. the various [[<locale>]] accesses, etc
    @ben-allen
    ben-allen committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    4f569ac View commit details
    Browse the repository at this point in the history

  2. fixed formatting of [[Day]] in datetimeformat.html

    @ben-allen
    ben-allen committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    de51194 View commit details
    Browse the repository at this point in the history

  3. typo in numberformat.html

    @ben-allen
    ben-allen committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    17c401c View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2023

  1. Refactor -- changed names of all fields/slots previously in camelCase to 

    their PascalCase equivalents. Exceptions: fields with two-character
names like [[nu]] and [[co]], fields that are only accessed dynamically,
as in [[<locale>]].
    @ben-allen
    ben-allen committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    4e45d8b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'capitalization' of https://github.com/ben-allen/ecma402 … 

    …into capitalization
    @ben-allen
    ben-allen committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    c33b586 View commit details
    Browse the repository at this point in the history