Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Only set dtf.[[HourCycle]] once. #662

Merged
merged 4 commits into from
Mar 28, 2022
Merged

Editorial: Only set dtf.[[HourCycle]] once. #662

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e8a3f6
Editorial: Only set dtf.[[HourCycle]] once.
Ms2ger Mar 21, 2022
3edfc24
Reorder
Ms2ger Mar 21, 2022
20bce68
Update spec/datetimeformat.html
Ms2ger Mar 24, 2022
5d8c0be
Try to clarify
Ms2ger Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions spec/datetimeformat.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ <h1>InitializeDateTimeFormat ( _dateTimeFormat_, _locales_, _options_ )</h1>
1. Set _dateTimeFormat_.[[Locale]] to _r_.[[locale]].
1. Let _calendar_ be _r_.[[ca]].
1. Set _dateTimeFormat_.[[Calendar]] to _calendar_.
1. Set _dateTimeFormat_.[[HourCycle]] to _r_.[[hc]].
1. Set _dateTimeFormat_.[[NumberingSystem]] to _r_.[[nu]].
1. Let _dataLocale_ be _r_.[[dataLocale]].
1. Let _timeZone_ be ? Get(_options_, *"timeZone"*).
Expand All @@ -95,7 +94,7 @@ <h1>InitializeDateTimeFormat ( _dateTimeFormat_, _locales_, _options_ )</h1>
1. Set _formatOptions_.[[&lt;_prop_&gt;]] to _value_.
1. Let _dataLocaleData_ be _localeData_.[[&lt;_dataLocale_&gt;]].
1. Let _hcDefault_ be _dataLocaleData_.[[hourCycle]].
1. Let _hc_ be _dateTimeFormat_.[[HourCycle]].
1. Let _hc_ be _r_.[[hc]].
Ms2ger marked this conversation as resolved.
Show resolved Hide resolved
1. If _hc_ is *null*, then
1. Set _hc_ to _hcDefault_.
Ms2ger marked this conversation as resolved.
Show resolved Hide resolved
1. If _hour12_ is *true*, then
Expand Down