Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: normalize property name iteration #592

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

jugglinmike
Copy link
Contributor

Prior to this commit, the variable named prop was not defined in two
of the loops within ToDateTimeOptions. Define it using the convention
for loops in ECMA262, and update the algorithm's similar loops to match.

Prior to this commit, the variable named `prop` was not defined in two
of the loops within ToDateTimeOptions. Define it using the convention
for loops in ECMA262, and update the algorithm's similar loops to match.
Copy link
Member

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I'm wondering here that since there's nothing quite special about being a "property name" and since we're just iterating a constant list, it should instead be For each element _prop_ of « ... » to simply things.

@ryzokuken ryzokuken added the editorial Involves an editorial fix label Jul 22, 2021
@jugglinmike
Copy link
Contributor Author

The wording in this patch is based on a similar step in the BasicFormatMatcher algorithm. There, the qualifier is necessary to disambiguate between other columns in the referenced table. That's not a concern here, but it could still be useful as a way to further contextualize the purpose of the list elements. That said, I'm happy to change this according to the editors' preference.

@ryzokuken
Copy link
Member

@jugglinmike you're right. Besides, either way, this is a net positive with respect to the status quo so let's merge this and discuss any further changes separately.

Thanks for the PR again! 😇

@ryzokuken ryzokuken merged commit 020acca into tc39:master Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Involves an editorial fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants