Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: Fix TimeZoneName issue in FormatDateTimePattern #573

Merged
merged 3 commits into from
Jun 7, 2021
Merged

Normative: Fix TimeZoneName issue in FormatDateTimePattern #573

merged 3 commits into from
Jun 7, 2021

Conversation

FrankYFTang
Copy link
Contributor

This was referenced May 7, 2021
Merged
Closed
ryzokuken
ryzokuken reviewed May 10, 2021
View reviewed changes
Copy link
Member

@ryzokuken ryzokuken left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is an editorial change? It seems like the value of fv could potentially be changed?

Also, you did not remove If _p_ is *"timeZoneName"*, then the String value may also depend on the value of the [[InDST]] field of _tm_.. Is that intentional?

Ms2ger
Ms2ger approved these changes May 10, 2021
View reviewed changes
spec/datetimeformat.html Outdated Show resolved Hide resolved
spec/datetimeformat.html Show resolved Hide resolved
anba
anba approved these changes May 10, 2021
View reviewed changes
spec/datetimeformat.html Outdated Show resolved Hide resolved
@FrankYFTang
Copy link
Contributor Author

Are you sure this is an editorial change? It seems like the value of fv could potentially be changed?

It is changed from "undefined behavior" to "defined behavior" so I will change the title to Normative.

Also, you did not remove If _p_ is *"timeZoneName"*, then the String value may also depend on the value of the [[InDST]] field of _tm_.. Is that intentional?

somehow I missed that. Fixed

@FrankYFTang FrankYFTang changed the title Editorial: Fix TimeZoneName issue in FormatDateTimePattern Normative: Fix TimeZoneName issue in FormatDateTimePattern May 10, 2021
@ryzokuken
Copy link
Member

2021-05-25: This PR got TC39-TG1 consensus.

@ryzokuken
Copy link
Member

2021-06-03: This PR got TC39-TG2 consensus.

@sffc
Copy link
Contributor

sffc commented Jun 3, 2021

2021-06-03 TG2 consensus: https://github.com/tc39/ecma402/blob/master/meetings/notes-2021-06-03.md#normative-fix-timezonename-issue-in-formatdatetimepattern

@ryzokuken
Copy link
Member

This PR has multiple positive reviews, no outstanding comments and TG1 and TG2 consensus. Merging.

@ryzokuken ryzokuken merged commit 9669a18 into tc39:master Jun 7, 2021
@ryzokuken ryzokuken mentioned this pull request Sep 27, 2021
Closed
@FrankYFTang FrankYFTang deleted the fixTimeZoneName branch September 27, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ms2ger Ms2ger Ms2ger approved these changes

@anba anba anba approved these changes

@ryzokuken ryzokuken ryzokuken approved these changes

@leobalter leobalter Awaiting requested review from leobalter

@gibson042 gibson042 Awaiting requested review from gibson042

Assignees

@Ms2ger Ms2ger

@leobalter leobalter

@gibson042 gibson042

@anba anba

@ryzokuken ryzokuken

Labels
normative
Projects
ECMA-402 Meeting Topics
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@FrankYFTang @ryzokuken @sffc @Ms2ger @anba @leobalter @gibson042