Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Change "Difficult" to "Expensive" in Stage 2 entrance criterion #557

Merged
merged 2 commits into from
Aug 12, 2021

Conversation

sffc
Copy link
Contributor

@sffc sffc commented Mar 12, 2021

No description provided.

@sffc sffc changed the title Change "Difficult" to "Expensive" in Stage 2 entrance criterion Meta: Change "Difficult" to "Expensive" in Stage 2 entrance criterion Mar 12, 2021
CONTRIBUTING.md Outdated
2. **Difficult to Implement in Userland**
1. Features in Intl must bring something to the table that a third-party library wouldn't be able to do with the same level of efficiency and performance. The champion can cite a heavy locale data dependency or a complex algorithm to satisfy this criterion.
2. **Expensive to Implement in Userland**
1. Features in Intl must bring something to the table that a third-party library wouldn't be able to do with the same level of efficiency, performance, and simplicity. The champion can cite a heavy locale data dependency or a complex algorithm to satisfy this criterion.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit pick: s/simplicity/complexity

The adjectives for Simple and simplicity are often seen as very subjective and relative to individual experiences.

The meaning of complexity here is not much different but would avoid triggering these issues, I hope so.

Suggested change
1. Features in Intl must bring something to the table that a third-party library wouldn't be able to do with the same level of efficiency, performance, and simplicity. The champion can cite a heavy locale data dependency or a complex algorithm to satisfy this criterion.
1. Features in Intl must bring something to the table that a third-party library wouldn't be able to do with the same level of efficiency, performance, and complexity. The champion can cite a heavy locale data dependency or a complex algorithm to satisfy this criterion.

Copy link
Member

@leobalter leobalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not blocking the approval on my nit picking. It seems good to land one way or another.

Copy link
Member

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM either way (wrt @leobalter's suggestion).

Copy link
Member

@zbraniecki zbraniecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion(optional): since we're revisiting it, would you be open to adjust the same level ... part?

As of now this sounds like if a proposal is at least on par with the cost of third party, it is passing the bar. I believe our intent here is to say that it has to be significantly more expensive to do X with third-party to pass the bar on extending the standard.

@sffc sffc requested a review from zbraniecki April 23, 2021 23:50
@sffc
Copy link
Contributor Author

sffc commented Apr 23, 2021

I rewrote the whole sentence to read:

Features in Intl must be significantly more efficient and less complex than a third-party library implementing the same feature.

Does this address your concern @zbraniecki ?

@ryzokuken
Copy link
Member

ping @zbraniecki

@ryzokuken ryzokuken added the meta label Jul 22, 2021
Copy link
Member

@zbraniecki zbraniecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thank you for addressing my comment

@sffc sffc merged commit 0e9c8ea into master Aug 12, 2021
@sffc sffc deleted the sffc-patch-1 branch August 12, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants