Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: Adding Intl.DisplayNames specification. #502

Merged
merged 19 commits into from
Jan 6, 2021

Conversation

FrankYFTang
Copy link
Contributor

Fixes #31.

Based on https://github.com/tc39/proposal-intl-displaynames which is ready for Stage 4.

@FrankYFTang
Copy link
Contributor Author

We need to address the issue @anba raised about "Conformance" section in this PR
tc39/proposal-intl-displaynames#78

spec/conventions.html Outdated Show resolved Hide resolved
spec/displaynames.html Outdated Show resolved Hide resolved
spec/displaynames.html Outdated Show resolved Hide resolved
spec/displaynames.html Outdated Show resolved Hide resolved
spec/displaynames.html Outdated Show resolved Hide resolved
spec/displaynames.html Outdated Show resolved Hide resolved
spec/displaynames.html Outdated Show resolved Hide resolved
spec/displaynames.html Outdated Show resolved Hide resolved
spec/displaynames.html Outdated Show resolved Hide resolved
spec/displaynames.html Outdated Show resolved Hide resolved
@leobalter
Copy link
Member

As my review got too verbose, I'd like to bring back a pending feedback from @anba:

https://tc39.es/ecma402/#conformance lists options which are allowed to have implementation-defined behaviour. For Intl.DisplayNames, the "style" and "type" options should probably be listed there. I'm not yet sure if it makes sense to allow implementation-defined behaviour for the "fallback" option, because I don't exactly know what other kind of fallback should happen here.

@FrankYFTang I've got some minor suggestions, all editorial which I can apply (probably tomorrow).

I can also help on the missing conformance part, please let me know!

FrankYFTang and others added 16 commits January 5, 2021 13:02
@FrankYFTang
Copy link
Contributor Author

@FrankYFTang I've got some minor suggestions, all editorial which I can apply (probably tomorrow).

Thanks. Great !

I can also help on the missing conformance part, please let me know!

That will be nice.

@leobalter
Copy link
Member

Ok, the conflicts are resolved and I'll take a look at this conformance part. I believe it's best to do in a follow up PR we work through this week.

@FrankYFTang
Copy link
Contributor Author

Ok, the conflicts are resolved and I'll take a look at this conformance part. I believe it's best to do in a follow up PR we work through this week.

Agree

@leobalter leobalter merged commit c57638b into tc39:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intl.DisplayNames API
3 participants