Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Change "be this value" to "be the this value" #476

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Editorial: Change "be this value" to "be the this value" #476

merged 1 commit into from
Jul 13, 2020

Conversation

mpcsh
Copy link
Member

@mpcsh mpcsh commented Jul 13, 2020

I noticed we're not consistent about whether we write

Let foo be this value

vs

Let foo be the this value

262 consistently uses the latter form, so this PR just unifies to that language.

@mpcsh mpcsh mentioned this pull request Jul 13, 2020
Merged
ljharb
ljharb approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches 262.

@leobalter leobalter merged commit fff9743 into master Jul 13, 2020
@leobalter leobalter deleted the the-this-value branch July 13, 2020 19:05
@leobalter
Copy link
Member

Thank you, @mpcsh !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@leobalter leobalter leobalter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpcsh @leobalter @ljharb