Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta: remove mistaken "infallibly" IDs from #2547 #2690

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Meta: remove mistaken "infallibly" IDs from #2547 #2690

merged 1 commit into from
Mar 11, 2022

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Mar 11, 2022

No description provided.

@ljharb ljharb added the meta label Mar 11, 2022
michaelficarra
michaelficarra approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably fine.

@ljharb
Copy link
Member Author

ljharb commented Mar 11, 2022

Since it's only been like a week, i didn't feel the need to oldIDs the infallibly ones, i assumed yall would agree.

@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Mar 11, 2022
@ljharb ljharb merged commit ada486f into tc39:main Mar 11, 2022
@ljharb ljharb deleted the fallibly branch March 11, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelficarra michaelficarra michaelficarra approved these changes

@bakkot bakkot bakkot approved these changes

Assignees
No one assigned
Labels
meta ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ljharb @michaelficarra @bakkot