-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normative: Add the at
method to Array, TypedArray, and String
#2286
Conversation
spec.html
Outdated
@@ -31728,6 +31744,21 @@ <h1>Properties of the Array Prototype Object</h1> | |||
<p>The Array prototype object is specified to be an Array exotic object to ensure compatibility with ECMAScript code that was created prior to the ECMAScript 2015 specification.</p> | |||
</emu-note> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this busted? There's no </emu-clause>
on this and the indentation is off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub can’t really handle expanding diffs on the web on a file as large as the spec.
spec.html
Outdated
<emu-alg> | ||
1. Let _O_ be ? ToObject(*this* value). | ||
1. Let _len_ be ? LengthOfArrayLike(_O_). | ||
1. Let _relativeIndex_ be ? ToInteger(_index_). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this ToIntegerOrInfinity
these days?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Let _relativeIndex_ be ? ToInteger(_index_). | |
1. Let _relativeIndex_ be ? ToIntegerOrInfinity(_index_). |
spec.html
Outdated
1. Let _O_ be ? RequireObjectCoercible(*this* value). | ||
1. Let _S_ be ? ToString(_O_). | ||
1. Let _len_ be the length of _S_. | ||
1. Let _relativeIndex_ be ? ToInteger(_index_). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Let _relativeIndex_ be ? ToInteger(_index_). | |
1. Let _relativeIndex_ be ? ToIntegerOrInfinity(_index_). |
spec.html
Outdated
@@ -31728,6 +31744,21 @@ <h1>Properties of the Array Prototype Object</h1> | |||
<p>The Array prototype object is specified to be an Array exotic object to ensure compatibility with ECMAScript code that was created prior to the ECMAScript 2015 specification.</p> | |||
</emu-note> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub can’t really handle expanding diffs on the web on a file as large as the spec.
spec.html
Outdated
<emu-alg> | ||
1. Let _O_ be ? ToObject(*this* value). | ||
1. Let _len_ be ? LengthOfArrayLike(_O_). | ||
1. Let _relativeIndex_ be ? ToInteger(_index_). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Let _relativeIndex_ be ? ToInteger(_index_). | |
1. Let _relativeIndex_ be ? ToIntegerOrInfinity(_index_). |
spec.html
Outdated
1. Let _O_ be the *this* value. | ||
1. Perform ? ValidateTypedArray(_O_). | ||
1. Let _len_ be _O_.[[ArrayLength]]. | ||
1. Let _relativeIndex_ be ? ToInteger(_index_). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Let _relativeIndex_ be ? ToInteger(_index_). | |
1. Let _relativeIndex_ be ? ToIntegerOrInfinity(_index_). |
3d0c24c
to
7a79833
Compare
We did this in #2493 instead, I guess. |
whoops |
2c0b6c5
to
3aafa24
Compare
No description provided.