Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: Generically forbid 402 method extensions in Forbidden Extensions #1920

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

rkirsling
Copy link
Member

Forbidden Extensions has a list of methods which are specified in ECMA-402 instead, but a few are missing; this PR rectifies that.

@rkirsling rkirsling changed the title Editorial: Forbidden Extensions misses a few 402 methods. Editorial: Update 402 method list in Forbidden Extensions Mar 27, 2020
@ljharb
Copy link
Member

ljharb commented Mar 27, 2020

Given that these are actually forbidden, this seems like a normative change to me, not an editorial one (altho not one I suspect needs consensus).

@rkirsling
Copy link
Member Author

My understanding is that the normative part is in each of the respective sections (e.g. BigInt.prototype.toLocaleString), while this bullet point is just being helpful by collecting the full list in one spot.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Touché

@bakkot
Copy link
Contributor

bakkot commented Mar 27, 2020

Hm, I'd lean towards considering this normative. BigInt.prototype.toLocaleString says

An ECMAScript implementation that includes the ECMA-402 Internationalization API must implement the BigInt.prototype.toLocaleString method as specified in the ECMA-402 specification. If an ECMAScript implementation does not include the ECMA-402 API the following specification of the toLocaleString method is used.

which reads to me as a less strict requirement than the "The behaviour of the following methods must not be extended except as specified in ECMA-402:" requirement which appears in Forbidden Extensions.

@michaelficarra
Copy link
Member

If we ask for consensus for this, the consensus we get should be for fast-tracking all 402 methods into 262 forbidden extensions, without requiring further approval from the committee.

@ljharb ljharb added needs consensus This needs committee consensus before it can be eligible to be merged. normative change Affects behavior required to correctly evaluate some ECMAScript source text and removed editorial change labels Mar 27, 2020
@rkirsling rkirsling changed the title Editorial: Update 402 method list in Forbidden Extensions Normative: Update 402 method list in Forbidden Extensions Mar 27, 2020
@rkirsling
Copy link
Member Author

Here's an attempt at a generic phrasing.

ljharb added a commit to tc39/agendas that referenced this pull request Mar 28, 2020
@rkirsling rkirsling changed the title Normative: Update 402 method list in Forbidden Extensions Normative: Generically forbid 402 method extensions in Forbidden Extensions Mar 28, 2020
@ljharb ljharb self-assigned this Mar 30, 2020
spec.html Outdated Show resolved Hide resolved
@ljharb ljharb added has consensus This has committee consensus. and removed needs consensus This needs committee consensus before it can be eligible to be merged. labels Mar 31, 2020
@bakkot bakkot added the editor call to be discussed in the next editor call label Apr 26, 2020
@ljharb ljharb removed the editor call to be discussed in the next editor call label Apr 29, 2020
@ljharb ljharb merged commit b907cc9 into tc39:master Apr 29, 2020
@rkirsling rkirsling deleted the forbidden-extensions-402 branch April 29, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has consensus This has committee consensus. normative change Affects behavior required to correctly evaluate some ECMAScript source text spec bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants