Normative: Add String.prototype.{trimStart/trimEnd} (+ trimLeft/trimRight) #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
ljharb
added
normative change
ljharb
approved these changes
Jul 25, 2018
sebmarkbage
approved these changes
Jul 25, 2018
claudepache
reviewed
Aug 14, 2018
|
Looks like this proposal is ready for Stage 4 (modulo editor reviews and @claudepache 's comment). Does anyone want to take on presenting it in the November 2018 TC39 meeting? |
|
@evilpie @sebmarkbage Feel free to reach out to me in case you cannot make it to the meeting. Happy to present it on your behalf. |
bterlson
approved these changes
Oct 24, 2018
bterlson
approved these changes
Jan 26, 2019
ljharb
added
has stage 4
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request for the stage 3 proposal https://github.com/tc39/proposal-string-left-right-trim. The proposal is/was championed by @sebmarkbage.
test262 tests: yes, tc39/test262@5931e31 and others
Rationale
ES5 standardized
String.prototype.trim. All major engines have also implemented correspondingtrimLeftandtrimRightfunctions - without any standard specification.For consistency with
padStart/padEndwe proposetrimStartandtrimEndandtrimLeft/trimRightas aliases required for web compatibility.Review notes
I wasn't quite sure where to put TrimString, but this follows String.prototype.replace with GetSubstitution by putting it inline.